Closed Bug 1658964 Opened 9 months ago Closed 8 months ago

Convert typed bookmarks, tabs, and history restriction characters/tokens to search mode

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
82 Branch
Iteration:
81.2 - Aug 10 - Aug 23
Tracking Status
firefox81 --- wontfix
firefox82 --- fixed

People

(Reporter: yoasif, Assigned: adw)

References

Details

(Keywords: nightly-community)

Attachments

(1 file)

Steps to reproduce:

  1. type %
  2. type a query

What happens:

The "tabs" icon/scope is not indicated; doesn't have an affordance.

Expected result:

I should have something in the UI that shows what search is selected in the scope bar.

An example of this can be seen in https://developer.apple.com/design/human-interface-guidelines/macos/buttons/scope-buttons/

I thought we had a bug for converting typed restriction chars, like %, to search mode (with the visible search mode indicator), but it doesn't look like it. That's the plan though, at least for the three local one-offs we have right now (bookmarks, tabs, history). This bug can be about that.

Summary: Active scope/search not indicated, has no affordance → Convert typed bookmarks, tabs, and history restriction characters/tokens to search mode
Severity: -- → S3
Type: defect → task
Points: --- → 2
Priority: -- → P2

Drew, that is also an issue, but the issue I was noting was about the affordance in the scope bar, not the address bar itself. Should I file a new bug? It looks exactly the same as this one for non-local searches (as they already show an affordance for the restriction character in the address bar).

Flags: needinfo?(adw)

What is the scope bar?

Flags: needinfo?(adw)

The search engine and local icons in the "this time search with" row.

The scope will be shown in the blue search mode indicator in the urlbar. UX hasn't indicated that we should also highlight/select the one-off, but we can ask them about that.

Given that the scope can be activated via the scope bar (and the keyword/restriction characters seem to be a shortcut), I think this makes the connection via scope and suggestions more obvious. This is widely used (see apple HIG link above) and is an affordance beyond the keyword (which is frankly not all that discoverable).

Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 81.2 - Aug 10 - Aug 23

This fixes this bug (bug 1658964), bug 1659714, bug 1659738, and bug 1659032.
They're all kind of related. It still needs more tests.

See Also: → 1660713
Blocks: 1661882
Attachment #9171523 - Attachment description: Bug 1658964 - Convert typed bookmarks, tabs, and history restriction characters/tokens to search mode. → Bug 1658964 - Convert local restriction chars to search mode and make other improvements to search mode.
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c777bf670c9
Convert local restriction chars to search mode and make other improvements to search mode. r=harry
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Blocks: 1659032
Blocks: 1659738
Blocks: 1659714
Blocks: 1660204
Regressions: 1663016
Regressions: 1663164
Blocks: 1663686
Regressions: 1665115
Regressions: 1672680
You need to log in before you can comment on or make changes to this bug.