1658964 - Convert typed bookmarks, tabs, and history restriction characters/tokens to search mode

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Asif Youssuff]

Steps to reproduce:

1. type %
2. type a query

What happens:

The "tabs" icon/scope is not indicated; doesn't have an affordance.

Expected result:

I should have something in the UI that shows what search is selected in the scope bar.

An example of this can be seen in https://developer.apple.com/design/human-interface-guidelines/macos/buttons/scope-buttons/

Comment 1

[Drew Willcoxon :adw]

I thought we had a bug for converting typed restriction chars, like %, to search mode (with the visible search mode indicator), but it doesn't look like it. That's the plan though, at least for the three local one-offs we have right now (bookmarks, tabs, history). This bug can be about that.

Comment 2

[Asif Youssuff]

Drew, that is also an issue, but the issue I was noting was about the affordance in the scope bar, not the address bar itself. Should I file a new bug? It looks exactly the same as this one for non-local searches (as they already show an affordance for the restriction character in the address bar).

Comment 3

[Drew Willcoxon :adw]

What is the scope bar?

Comment 4

[Asif Youssuff]

The search engine and local icons in the "this time search with" row.

Comment 5

[Drew Willcoxon :adw]

The scope will be shown in the blue search mode indicator in the urlbar. UX hasn't indicated that we should also highlight/select the one-off, but we can ask them about that.

Comment 6

[Asif Youssuff]

Given that the scope can be activated via the scope bar (and the keyword/restriction characters seem to be a shortcut), I think this makes the connection via scope and suggestions more obvious. This is widely used (see apple HIG link above) and is an affordance beyond the keyword (which is frankly not all that discoverable).

Comment 7

[Drew Willcoxon :adw]

Attachment: Bug 1658964 - Convert local restriction chars to search mode and make other improvements to search mode.

This fixes this bug (bug 1658964), bug 1659714, bug 1659738, and bug 1659032.
They're all kind of related. It still needs more tests.

Comment 8

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f222d97eafc48323b4e8e9a0ce190267989b6f51

Comment 9

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c0b5e38c75c5e7877c8645f47ef178338141f82

Comment 10

[Drew Willcoxon :adw]

With update2 enabled (as usual on Nightly): https://treeherder.mozilla.org/#/jobs?repo=try&revision=36b2d8f376a835567dd52420f539e3a4a955bd98

With update2 disabled to simulate non-Nightly: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d970ba341e64e6189744846c2f35aa2462f19b92

Comment 11

[Drew Willcoxon :adw]

Try pushes with the latest m-c plus several urlbar patches on autoland, with a small test failure in https://phabricator.services.mozilla.com/D87510 also fixed:

With update2 enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08d8605658780b1a8adda56991e99648dce2a1d7

Disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b85f653f0b2ba844a29bef04f3767d4fdec2789

Comment 12

[Drew Willcoxon :adw]

Update2 enabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ea6ebd069978b2bdebce60c62ff39e307f4ba01

Disabled: https://treeherder.mozilla.org/#/jobs?repo=try&revision=63d4db7de0bc6b1f18d2ec21db725b5c5fd0278a

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c777bf670c9
Convert local restriction chars to search mode and make other improvements to search mode. r=harry

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8c777bf670c9