Closed Bug 1662124 Opened 6 months ago Closed 6 months ago

element.setPointerCapture should throw NotFoundError if the pointer id is invalid

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(2 files)

Per https://w3c.github.io/pointerevents/#setting-pointer-capture, calling the element.setPointerCapture with invalid pointer_id should throw NotFoundError, right now we throw InvalidPointerId.

This could fix the WPT failure of pointerevent_setpointercapture_invalid_pointerid.html, https://wpt.fyi/results/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html?label=master&label=experimental&aligned.

Assignee: nobody → echen
Status: NEW → ASSIGNED
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f0b1fa85339
element.setPointerCapture should throw NotFoundError if the pointer id is invalid; r=smaug
Flags: needinfo?(echen)
Keywords: dev-doc-needed

Now we can pass the wpt one which is no longer a manual test.

Depends on D88859

Blocks: 1613410
Flags: needinfo?(echen)
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/225ee73a5a47
element.setPointerCapture should throw NotFoundError if the pointer id is invalid; r=smaug
https://hg.mozilla.org/integration/autoland/rev/cd2565a9142b
Remove test_pointerevent_{setpointercapture/releasepointercapture}_invalid_pointerid-manual.html; r=smaug
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

I'm updating the Binary comat data for this: https://github.com/mdn/browser-compat-data/blob/master/api/Element.json#L8123-L8152

The story for FF desktop is clear, but the FF for Android indicates that this is still stuck behind dom.w3c_pointer_events.enabled from build 41".
Can you confirm that this is incorrect - ie the most likely assumption is that this is supported all the time from version "59" just like the desktop build.

Last of all, how can I "more generally" check if a core feature is selectively not run on FF for android (so I don't need to ask you this question next time).

Flags: needinfo?(echen)

The story for FF Android is a bit different, we didn't ship pointer event on FF Android along with FF Desktop from 59.
We shiped it while we move FF Android to GeckoView, see https://bugzilla.mozilla.org/show_bug.cgi?id=1507495. But since it depend on runtime status on FF Android, so we need to update the pref dynamically.

In general, we try to maintain our pref setup in a central place, https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml, but pref could be overwrite from other place, too.

Flags: needinfo?(echen)
You need to log in before you can comment on or make changes to this bug.