1662124 - element.setPointerCapture should throw NotFoundError if the pointer id is invalid

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Edgar Chen [:edgar]]

Per https://w3c.github.io/pointerevents/#setting-pointer-capture, calling the element.setPointerCapture with invalid pointer_id should throw NotFoundError, right now we throw InvalidPointerId.

This could fix the WPT failure of pointerevent_setpointercapture_invalid_pointerid.html, https://wpt.fyi/results/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html?label=master&label=experimental&aligned.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1662124 - element.setPointerCapture should throw NotFoundError if the pointer id is invalid;

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f90cd443a21c5784ae382475afce533a9d3f07da

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0b1fa85339
element.setPointerCapture should throw NotFoundError if the pointer id is invalid; r=smaug

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for morchitest failures on test_bug1080361.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/457b43be241b3b6d8b72a9a546830bd0df3a4272
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314508036&repo=autoland&lineNumber=4822

Please also check failures on pointerevent_releasepointercapture_invalid_pointerid-manual.html -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314508036&repo=autoland&lineNumber=4822

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1662124 - Remove test_pointerevent_{setpointercapture/releasepointercapture}_invalid_pointerid-manual.html;

Now we can pass the wpt one which is no longer a manual test.

Depends on D88859

Comment 6

[Edgar Chen [:edgar]]

silly me, there are some tests that need an update as well.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f37ac4f1ba6916fb1c5eaa1b4988d5b9b981791&group_state=expanded

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/225ee73a5a47
element.setPointerCapture should throw NotFoundError if the pointer id is invalid; r=smaug
https://hg.mozilla.org/integration/autoland/rev/cd2565a9142b
Remove test_pointerevent_{setpointercapture/releasepointercapture}_invalid_pointerid-manual.html; r=smaug

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/225ee73a5a47
https://hg.mozilla.org/mozilla-central/rev/cd2565a9142b

Comment 9

[Hamish Willee]

I'm updating the Binary comat data for this: https://github.com/mdn/browser-compat-data/blob/master/api/Element.json#L8123-L8152

The story for FF desktop is clear, but the FF for Android indicates that this is still stuck behind dom.w3c_pointer_events.enabled from build 41".
Can you confirm that this is incorrect - ie the most likely assumption is that this is supported all the time from version "59" just like the desktop build.

Last of all, how can I "more generally" check if a core feature is selectively not run on FF for android (so I don't need to ask you this question next time).

Comment 10

[Edgar Chen [:edgar]]

The story for FF Android is a bit different, we didn't ship pointer event on FF Android along with FF Desktop from 59.
We shiped it while we move FF Android to GeckoView, see https://bugzilla.mozilla.org/show_bug.cgi?id=1507495. But since it depend on runtime status on FF Android, so we need to update the pref dynamically.

In general, we try to maintain our pref setup in a central place, https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml, but pref could be overwrite from other place, too.