1662143 - Windows High Contrast Mode issues in multistage about:welcome

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Emily McMinn :emcminn]

A couple of small issues with HCM came up in the a11y audit of the multistage about:welcome screens. These weren't considered to be blocking, but it would be nice to get them fixed; hopefully by someone using a Windows build for easier testing.

The two HCM issues are:

1. the primary button loses its border so it's not obvious it's a button and
2. the pagination ("step") indicators disappear completely.

These issues could likely both be fixed by correctly setting color inheritance on the button border and the step indicators, so that the inverted colors are able to be set by HCM. Figuring out which color to inherit might be tricky.

There's also potentially an issue with the color contrast of the primary button focus indicator; there was a fix for this in 1660259 but we should take a second look and make sure the correct colors are used.

(To test High Contrast Mode, go to Windows Ease of Access settings -> High contrast -> Turn on high contrast.)

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1662143 - Fix for Windows High Contrast Mode buttons and indicators

Comment 3

[Emily McMinn :emcminn]

Attachment: Windows try builds

Comment 4

[Emily McMinn :emcminn]

Attachment: Link to Windows x64 build

Comment 5

[Emily McMinn :emcminn]

Hi Asa; since you were the one to find these issues originally, would you mind verifying that this build fixes them? You can download the Windows build here:

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CRIpzbzkTtKta-PYv88i3Q/runs/0/artifacts/public/build/setup.exe

Let me know if anything comes up! Thanks :)

Comment 6

[Asa Dotzler [:asa]]

(In reply to Emily McMinn :emcminn from comment #5)

Hi Asa; since you were the one to find these issues originally, would you mind verifying that this build fixes them? You can download the Windows build here:

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CRIpzbzkTtKta-PYv88i3Q/runs/0/artifacts/public/build/setup.exe

Let me know if anything comes up! Thanks :)

Happy to test. I couldn't get that stub installer to work. Can you link me the full installer?

Comment 7

[Emily McMinn :emcminn]

Oh, sorry about that! Maybe try:

https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CRIpzbzkTtKta-PYv88i3Q/runs/0/artifacts/public/build/install/sea/target.installer.exe

Comment 8

[Asa Dotzler [:asa]]

About Welcome in Windows High Contrast Mode now looks great!! Thank you.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/920dc8d7a727
Fix for Windows High Contrast Mode buttons and indicators r=pdahiya

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/920dc8d7a727

Comment 11

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using Firefox Nightly 83.0a1 (Build ID: 20201018211631) on Windows 10 x64:

• The buttons keep their borders on all 3 pages of the "about:welcome" when the "High Contrast mode" is enabled.
• The "paginations" are correctly displayed on all 3 pages of the "about:welcome" when the "High Contrast mode" is enabled.