1662372 - The buttons from the "Set browser as default" notification bar are not visibly focused using keyboard navigation (macOS and Linux only)

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 82.0a1 - Build ID: 20200831215215
• Firefox Beta 81.0b4 - Build ID: 20200829200810

[Affected Platforms]:

• macOS 10.15
• Ubuntu 18.04 x64

[Prerequisites]:

• Have a new Firefox profile.
• The Firefox browser is NOT set as default.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Additional step for Nightly: Open a new tab.
3. Press the "Tab" key two times and observe the behavior.

[Expected result]:

• The "Set as Default" button is focused.

[Actual result]:

• There are no browser elements focused.

[Notes]:

• This issue is reproducible with the "Close this message" button from the notification bar.
• The buttons are working as expected if the "Space" key is pressed, even if are not visibly focused.
• This issue is not reproducible on Windows.
• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

This seems to be duplicate of bug 1662376, NI Emily to verify and triage. Thanks

Comment 2

[Emily McMinn :emcminn]

Attachment: Bug 1662372 - Set focus styles for notification bar buttons

Comment 3

[Emily McMinn :emcminn]

I've attached a patch which gives focus styles to both buttons when they are forcibly focused (i.e. through the console); however I haven't been able to replicate this bug because I'm having a (possibly worse) one: I can't reach the notification bar with the keyboard at all. Focus jumps right from the bookmarks bar to the content window. Manually adding a tabindex to one of the parent notification elements allows me to tab to the bar, but not interact with it. Tabindex on the button doesn't even do that.

I'm on MacOS 10.14 so it could be a Mojave-specific issue, but I'm guessing this is a larger bug that should be addressed.

Jared, since you were the last person to do a bunch of work here, would you mind taking a look? I have a feeling this has something to do with the stacking context, which I'm not familiar with.

Comment 4

[Tim Nguyen :ntim]

Have you checked whether -moz-user-focus is never set to ignore? none also suppresses focus I think.

Anyway, I think it would be helpful to know what regressed this, to get closer to the exact issue.
Marius, would it be possible to get a regression range?

Thanks!

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

Hi Tim, I've tried using the Mozregression tool to find a regression window, however, it seems that the buttons are not visible focused during keyboard navigation since the implementation of the "Set browser as default" notification bar in bug 1656494.

Also, Emily could you please go to the macOS "System Preferences" > "Keyboard" > "Shortcuts" tab and verify if the "All controls" option from the bottom-left part of the window is checked? I'm asking this because it seems that if the "Text boxes and lists only" option is checked instead the buttons from the notification bar cannot be focused at all.

Comment 6

[Emily McMinn :emcminn]

Hi Marius, setting 'All controls', along with the attached style patch, seems to work! Are we okay to rely on that, that users who need keyboard access here would have that setting turned on?

• The Enter key still isn't working to access the buttons (as per Bug 1662376), I'll see if it's possible to add a fix for that to this patch.

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

Hi Emily, from what we know until now on macOS in order to access all the browser elements through keyboard navigation we would need to have the "All controls" option enabled.
@Ed, can you weigh in on this, please?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

The work I did recently on the notifications didn't change the markup, but mostly just the styling. The stacking context shouldn't have changed. "All controls" will need to be enabled to tab through controls on macOS. If this is working with "All controls" enabled on macOS then I think the only bug here would be related to Ubuntu 18.04 x64.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aa9e98a98b4
Set focus styles for notification bar buttons r=dao

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0aa9e98a98b4

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (85.0a1 Build ID - 20201117215529) installed, Linux Mint 20 x64, and Mac 10.15. Now I can confirm that the buttons from the "Set browser as default" notification bar are visibly focused when using keyboard navigation.

Comment 12

[Dão Gottwald [:dao]]

Please verify with the popup blocked notification bar as well: http://www.popuptest.com/popuptest1.html
Also please verify on Windows since the fix is shared across platforms.

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

Hi Dao, I have verified this issue and I can confirm the following:

• The buttons from the "Popup blocked" notification are successfully focused through keyboard navigation (verified using the latest Firefox Nightly 85.0a1 Build ID - 20201117215529 installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15).
• The buttons from the "Set browser as default" notification are successfully focused through keyboard navigation (verified using the latest Firefox Nightly 85.0a1 Build ID - 20201117215529 installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15).

Also, I've observed that on Windows the old keyboard focus for the "Close this message" button still persists and overlaps the new one, but I've logged a separate issue for that (Bug 1678018).

Considering the above I am marking this issue as Verified.