Closed Bug 1678018 Opened 4 years ago Closed 3 years ago

[Windows] The old keyboard focus of the "Close this message" button wrongly overlaps the new one on the "Set browser as default" and "Popup blocked" browser notifications

Categories

(Toolkit :: Themes, defect, P2)

Product:
Toolkit
Component:
Themes
Platform:
Desktop
Windows
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- verified

People

(Reporter: mcoman, Assigned: emcminn)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

ss of the issue.png
19.24 KB, image/png
Details
Bug 1678018 - Remove obsolete and redundant focus ring from notification bar close button.
47 bytes, text/x-phabricator-request
Details | Review
Attached image ss of the issue.png —

[Notes]

[Affected versions]:

  • Firefox Nightly 85.0a1 - Build ID: 20201118041908

[Affected Platforms]:

  • Windows 10 x64

[Prerequisites]:

  • The Firefox browser is not set as default.
  • Have a new Firefox profile

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Open a new tab and press the "Tab" key four times.
  3. Observe the "Close this message button" from the "Set browser as default" browser notification.

[Expected result]:

  • Only one focus is successfully displayed and centered on the button.

[Actual result]:

  • The old focus overlaps the new one.

[Additional Notes]:

  • Attached a screenshot of the issue.
  • This issue is also reproducible with the "Popup blocked" browser notification.
  • This issue is not reproducible on Mac and Linux.

@Dao, could you please take a look over this issue?

Flags: needinfo?(dao+bmo)

Emily, would you look into this?

Blocks: 1633235
Severity: S3 → S4
Flags: needinfo?(dao+bmo) → needinfo?(emcminn)
Keywords: regression
Priority: -- → P2
Regressed by: 1662372
Has Regression Range: --- → yes

For sure, I'll take a look.

Assignee: nobody → emcminn
Flags: needinfo?(emcminn)
Attachment #9188664 - Attachment description: Bug 1678018 - test patch for notification bar css → Bug 1678018 - test patch for notification bar css (DRAFT)
Attachment #9188664 - Attachment description: Bug 1678018 - test patch for notification bar css (DRAFT) → Bug 1678018 - test patch for notification bar css
Attachment #9188664 - Attachment description: Bug 1678018 - test patch for notification bar css → Bug 1678018 - Remove overlapping focus ring for notification bar buttons
Attachment #9188664 - Attachment description: Bug 1678018 - Remove overlapping focus ring for notification bar buttons → Bug 1678018 - Remove obsolete and redundant focus ring from notification bar close button.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f773496e3fd
Remove obsolete and redundant focus ring from notification bar close button. r=dao

https://hg.mozilla.org/mozilla-central/rev/3f773496e3fd

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox85: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (85.0a1 Build ID - 20201126093916) installed on Windows 10 x64. Now I can confirm that only the new focus is displayed on the "Close this message" button.

Status: RESOLVED → VERIFIED
status-firefox85: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: