1662425 - [Wayland] Crash nsWaylandDisplay::DispatchEventQueue()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

We can crash at nsWaylandDisplay::DispatchEventQueue() when mDisplay/mEventQueue is already released. I happens when nsWaylandDisplay::DispatchEventQueue() is performed after nsWaylandDisplay release.

We need to keep nsWaylandDisplay around until any active loop->PostTask(NewRunnableFunction(...)) is pending.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1662425 [Wayland] Create nsWaylandDisplay as ref counted, r?jhorak

• Create nsWaylandDisplay as a ref-counted struct to avoid potential delete when a display is used.
• Don't use Mutex to access all display array operations. Use only write mutex when the array is modified / released.
• Store all wayland displays in nsTArray instead of fixed plain C array.
• Release all displays before we close Gtk display to make sure we quit before Gtk connections are closed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00a41c5183d7
[Wayland] Create nsWaylandDisplay as ref counted, r=jhorak

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 00a41c5183d7 (bug 1662425) for linux leakcheck failures.
https://hg.mozilla.org/integration/autoland/rev/ab20cc86e07fc3f5ccf46ecf214361ff264b6098

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=00a41c5183d7b3fedd9a632cccff8d0d3b970f60&selectedTaskRun=aE9K-NnGQpqKHNcXKolN3w.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314801498&repo=autoland&lineNumber=2161

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Related to https://bugzilla.mozilla.org/show_bug.cgi?id=1505307#c1 so we need to clear the array.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b402033322
[Wayland] Create nsWaylandDisplay as ref counted, r=jhorak

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/46b402033322