1505307 - leakcheck | default process: 4 bytes leaked (nsTArray_base) with wayland enabled (but not used)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Mike Hommey [:glandium]]

See https://hg.mozilla.org/try/rev/b84b5c8afaf7046fc5f969f9a91c29e09795c0a2

e.g.

[task 2018-11-07T03:46:12.974Z] 03:46:12     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 1056
[task 2018-11-07T03:46:12.975Z] 03:46:12     INFO - 
[task 2018-11-07T03:46:12.976Z] 03:46:12     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2018-11-07T03:46:12.977Z] 03:46:12     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
[task 2018-11-07T03:46:12.978Z] 03:46:12     INFO -    0 |TOTAL                                 |       42        8| 3733887        1|
[task 2018-11-07T03:46:12.987Z] 03:46:12     INFO - 1764 |nsTArray_base                         |        8        8| 1700362        1|
[task 2018-11-07T03:46:12.988Z] 03:46:12     INFO - 
[task 2018-11-07T03:46:12.989Z] 03:46:12     INFO - nsTraceRefcnt::DumpStatistics: 1898 entries
[task 2018-11-07T03:46:12.990Z] 03:46:12     INFO - TEST-INFO | leakcheck | default process: leaked 1 nsTArray_base
[task 2018-11-07T03:46:12.995Z] 03:46:12    ERROR - TEST-UNEXPECTED-FAIL | leakcheck | default process: 8 bytes leaked (nsTArray_base)

This happens on all mochitests (and some others) jobs on debug builds, with wayland enabled, but running on X11.

Comment 1

[Mike Hommey [:glandium]]

The "leak" comes from https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/widget/gtk/WindowSurfaceWayland.cpp#140 because that never runs the destructor.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Thanks, I'll look at it.

Comment 3

[Mike Hommey [:glandium]]

Can you take bug 1504904 too?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mike Hommey [:glandium] from comment #3)
> Can you take bug 1504904 too?

Sure.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1505307 - Don't use nsCOMPtr array to track Wayland display connections, r=jhorak

As we have only two wl_display connections it's a bit overkill to track it at nsCOMPtr array
and rather use a fixed-length one.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1505307 - Don't use nsCOMPtr array to track Wayland display connections, r=jhorak

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f1158e5e0ce
Don't use nsCOMPtr array to track Wayland display connections, r=jhorak

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2f1158e5e0ce