1662538 - Implement localization of paper names in the fallback paper-sizes list

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P2)

Description

[Jonathan Kew [:jfkthame]]

Followup to bug 1659781: the list landed there with hard-coded en-US names, but we should make them localizable. (The appropriate localizable strings already landed in printUI.ftl, but are not used by the code at present.)

Probably we should actually extend nsIPaper to expose both a (fixed) internal "key" and a (localizable) "display name" for the paper, so that code can be clear about which kind of name it wants to work with.

Comment 1

[Jonathan Watt [:jwatt]]

I'd been thinking we probably need a separate "internal" name and "display" name given the issues Erik has been working through.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1662538 - patch 1 - Make nsIPaper expose a non-localizable .id in addition to a localizable .name attribute.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1662538 - patch 2 - Localize paper names in the fallback paper size list used for Save to PDF.

Depends on D90073

Comment 4

[Jonathan Kew [:jfkthame]]

Attaching a couple patches to get started here, but not intending these should land until after the bump to 83. We also need to check what additional adjustments (e.g. in front-end or platform-specific code) may be needed to work with the changes; some code may want to change from using nsIPaper.name to using .id.

Comment 5

[Jonathan Kew [:jfkthame]]

FWIW, as they stand these patches definitely break things at least on Linux; probably the gtk code needs to change which attribute it's using somewhere. I'll try to look into this and see what fixups are needed.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1662538 - patch 3 - Update front-end code to use nsIPaper.id instead of .name where appropriate.

Depends on D90074

Comment 7

[Jonathan Kew [:jfkthame]]

The patches above should also resolve bug 1664017, as they result in using localized paper names for the UI on all platforms.

Comment 8

[Jonathan Kew [:jfkthame]]

Oh, there's (at least) one more piece to take care of here: the PrintData that we pass over IPC needs updating to support paperId, and we can drop its (Windows-specific) paperData field.

Comment 9

[Jonathan Kew [:jfkthame]]

(In reply to Jonathan Kew (:jfkthame) from comment #8)

Oh, there's (at least) one more piece to take care of here: the PrintData that we pass over IPC needs updating to support paperId, and we can drop its (Windows-specific) paperData field.

Correction: we do pass the paperId there, of course - it's what now lives in the paperName field. (I'm inclined to do a more extensive renaming to make this less confusing, but that should be a separate no-functional-changes followup.)

However, I do think we can drop the paperData field altogether, as that is identical to the paperName (id), just stored in a different form.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bbc5c0b580f
patch 1 - Make nsIPaper expose a non-localizable .id in addition to a localizable .name attribute. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/cd6aaf5e193c
patch 2 - Localize paper names in the fallback paper size list used for Save to PDF. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/b95fc1c0599b
patch 3 - Update front-end code to use nsIPaper.id instead of .name where appropriate. r=sfoster

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2bbc5c0b580f
https://hg.mozilla.org/mozilla-central/rev/cd6aaf5e193c
https://hg.mozilla.org/mozilla-central/rev/b95fc1c0599b