Closed
Bug 1665904
Opened 5 years ago
Closed 5 years ago
Change paperName to paperId where we're using the internal ID string rather than a human-friendly name
Categories
(Core :: Printing: Setup, task)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(2 files)
Now that (since bug 1662538) nsIPaper exposes both a fixed internal id and a (localizable) human-friendly name for a given paper size record, we use the id as the primary identifier to store and pass around.
So we should rename the paperName member of the IPDL PrintData struct as paperId, and similarly rename the associated variables/fields in platform and front-end code.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D90790
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa5bcb0257aa
Rename paperName to paperId for better clarity (platform). r=jwatt
https://hg.mozilla.org/integration/autoland/rev/37fac5f10880
Rename paperName to paperId for better clarity (front-end). r=jwatt
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aa5bcb0257aa
https://hg.mozilla.org/mozilla-central/rev/37fac5f10880
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•