Closed Bug 1662583 Opened 3 years ago Closed 3 years ago

Add tests for JS code-coverage with off-thread parsing

Categories

(Core :: JavaScript Engine, task, P2)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(2 files)

Bug 1662583 - Add JS tests for code-coverage / off-thread-parse combination. r?arai
47 bytes, text/x-phabricator-request
Details | Review
Bug 1662583 - Skip Memory-takeCensus-11.js JS test under code-coverage. r?arai
47 bytes, text/x-phabricator-request
Details | Review

We don't seem to have any tests for the code-coverage machinery and the off-thread parse combination. Bug 1658631 is making changes to this code so tests are helpful.

This test fails when run with --code-coverage because that flag keeps the
top-level scripts of each file alive which messes with the census
expectations.

Depends on D89059

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d0826226aba
Add JS tests for code-coverage / off-thread-parse combination. r=arai
https://hg.mozilla.org/integration/autoland/rev/2a30f4926e78
Skip Memory-takeCensus-11.js JS test under code-coverage. r=arai

https://hg.mozilla.org/mozilla-central/rev/0d0826226aba
https://hg.mozilla.org/mozilla-central/rev/2a30f4926e78

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.