Closed
Bug 166269
Opened 22 years ago
Closed 22 years ago
"Save As Web Page complete" saves html only
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugzilla3, Assigned: adamlock)
References
()
Details
(Whiteboard: [geekweb-fixed])
Attachments
(1 file)
1.70 KB,
patch
|
Brade
:
review+
kinmoz
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
When I save the complete page, only html is saved and js, css and images are left out. Same for any page of the above site. Eg. the specified link doesn't contain either national charset or form elements inside table cells. That's why I don't believe it's a duplicate of bug 119146. The link does not validate correctly but I can't go further because, when I save the complete page locally using IE6 (it works as expected), I can't reproduce the problem with Mozilla. If I could, then I would try to correct the html errors to see if they affect this bug.
![]() |
||
Comment 1•22 years ago
|
||
happens on linux too.
Assignee: law → adamlock
OS: Windows 2000 → All
Hardware: PC → All
Investigating. I can reproduce this on Win32 and it even crashed when I tried to save mozilla.org. The persist object has only had one small change recently for bug 164917.
Some javascript in the page was inserting a table element with an empty background tag, i.e. <table height="260" background="" border="0" cellspacing="0" cellpadding="0"> This empty string key was fouling up the enumeration of the URIs causing it to abort before any were saved. The fix is to test for empty URIs and not persist them. A simple patch follows.
Small patch adds a test for empty URIs, corrects a bad return value and contains a one line fix to test the uri returned by NS_NewURI to harden against protocol handlers such as irc: that don't implement NewURI properly (see bug 166593) Kathy can you review this please? Thanks
Comment 5•22 years ago
|
||
Comment on attachment 97773 [details] [diff] [review] Patch r=brade
Attachment #97773 -
Flags: review+
Comment on attachment 97773 [details] [diff] [review] Patch sr=kin@netscape.com
Attachment #97773 -
Flags: superreview+
Comment 7•22 years ago
|
||
Comment on attachment 97773 [details] [diff] [review] Patch a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #97773 -
Flags: approval+
Fix checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•22 years ago
|
Whiteboard: [geekweb-fixed]
Verified as fixed using 2002090511. Thank you people for the fast fix.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•