"Save As Web Page complete" saves html only

VERIFIED FIXED

Status

Core Graveyard
File Handling
VERIFIED FIXED
15 years ago
a year ago

People

(Reporter: Dimitrios, Assigned: Adam Lock)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [geekweb-fixed], URL)

Attachments

(1 attachment)

1.70 KB, patch
Kathleen Brade
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

15 years ago
When I save the complete page, only html is saved and js, css and images are
left out. Same for any page of the above site. Eg. the specified link doesn't
contain either national charset or form elements inside table cells. That's why
I don't believe it's a duplicate of bug 119146.

The link does not validate correctly but I can't go further because, when I save
the complete page locally using IE6 (it works as expected), I can't reproduce
the problem with Mozilla. If I could, then I would try to correct the html
errors to see if they affect this bug.
(Reporter)

Updated

15 years ago
Blocks: 115634
happens on linux too.
Assignee: law → adamlock
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 2

15 years ago
Investigating. I can reproduce this on Win32 and it even crashed when I tried to
save mozilla.org.

The persist object has only had one small change recently for bug 164917.
(Assignee)

Comment 3

15 years ago
Some javascript in the page was inserting a table element with an empty
background tag, i.e.

<table height="260" background="" border="0" cellspacing="0" cellpadding="0">

This empty string key was fouling up the enumeration of the URIs causing it to
abort before any were saved. The fix is to test for empty URIs and not persist them.

A simple patch follows.
(Assignee)

Comment 4

15 years ago
Created attachment 97773 [details] [diff] [review]
Patch

Small patch adds a test for empty URIs, corrects a bad return value and
contains a one line fix to test the uri returned by NS_NewURI to harden against
protocol handlers such as irc: that don't implement NewURI properly (see bug
166593)

Kathy can you review this please? Thanks

Comment 5

15 years ago
Comment on attachment 97773 [details] [diff] [review]
Patch

r=brade
Attachment #97773 - Flags: review+

Comment 6

15 years ago
Comment on attachment 97773 [details] [diff] [review]
Patch

sr=kin@netscape.com
Attachment #97773 - Flags: superreview+

Comment 7

15 years ago
Comment on attachment 97773 [details] [diff] [review]
Patch

a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #97773 - Flags: approval+
(Assignee)

Comment 8

15 years ago
Fix checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Whiteboard: [geekweb-fixed]
(Reporter)

Comment 9

15 years ago
Verified as fixed using 2002090511. Thank you people for the fast fix.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.