1663013 - getting "Telemetry::CoveragePing ERROR no endpoint base set" error logs in Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

As reported by Wayne, there can be some error logs
Telemetry::CoveragePing ERROR no endpoint base set

Not sure why I haven't seen them.
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/pings/CoveragePing.jsm#50

I think basically COVERAGE_ENABLED_PREF should be checked first.
But for ease of fixing, we might add a pref to avoid this.

https://searchfox.org/comm-central/search?q=toolkit.coverage.enabled&path=

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1663013_telemetry_coverage.patch

The easy fix...

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1663013 - don't check toolkit.coverage.endpoint.base before we know it's going to be needed. r=janerik

Comment 3

[Magnus Melin [:mkmelin]]

Would be interested to know how coverage is used. I can't find any code point that enables it.

Comment 4

[Khushil Mistry [:khushil324]]

Comment on attachment 9173856 [details] [diff] [review]
bug1663013_telemetry_coverage.patch

Looks good to me after looking at the firefox changes. r=khushil

Comment 5

[Jan-Erik Rediger [:janerik]]

Docs for this ping are here: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/coverage-ping.html
From that:

The ping is disabled by default. It is intended to be enabled for users on an experimental basis using the preference toolkit.coverage.enabled.

So I assume this would be enabled if needed through experiments. However I'm not aware of any that's still using it.
The patch still makes sense, we shouldn't need to check any additional prefs if it's not even enabled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b569f741d6
don't check toolkit.coverage.endpoint.base before we know it's going to be needed. r=janerik

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e5b569f741d6

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9173856 [details] [diff] [review]
bug1663013_telemetry_coverage.patch

[Triage Comment]
We should take the prefs-patch only on beta and for 78 to avoid the extra error logs.
Not needed on trunk.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9173856 [details] [diff] [review]
bug1663013_telemetry_coverage.patch

[Triage Comment]
Approved for beta.
Approved for esr78.

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 81.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/d81b8c90b176

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/066438c02c3b