Closed Bug 1663053 Opened 4 years ago Closed 4 years ago

Crash print previewing PDF and changing settings rapidly

Categories

(Core :: Printing: Setup, defect, P1)

defect

Tracking

()

VERIFIED FIXED
82 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- verified
firefox82 --- verified

People

(Reporter: jwatt, Assigned: hiro)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v81])

Attachments

(1 file)

Opening https://www.irs.gov/pub/irs-pdf/f1040.pdf in our new print preview UI and changing Landscape <-> Portrate rapidly crashes. Using macOS.

Both current Nightly and Beta (post-uplifts) with print.tab_modal.enabled; haven't tested pref off.

Can definitely reproduce using keyboard navigation (rapidly toggling arrow keys). Sample crash report: https://crash-stats.mozilla.org/report/index/c70b53d8-f76a-44ed-a6dd-558350200903

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED

Though I pushed a fix, but I'd really like to write an automated test for this.

QA Whiteboard: regression,
Regressed by: 1662426
Has Regression Range: --- → yes
Priority: P2 → P1
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/795583e2dc21
Bail out from HTMLCanvasElement::CallPrintCallback is `mPrintState` has already destroyed. r=jwatt

Comment on attachment 9173895 [details]
Bug 1663053 - Bail out from HTMLCanvasElement::CallPrintCallback is mPrintState has already destroyed. r?jwatt

Beta/Release Uplift Approval Request

  • User impact if declined: Crash
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open https://www.irs.gov/pub/irs-pdf/f1040.pdf
  1. Ctrl+P to open the print preview window
  2. Change "Orientation" rapidly by using arrow keys
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's just a simple null check bailing out code to avoid the crash
  • String changes made/needed: None
Attachment #9173895 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Severity: -- → S1

Thanks a lot for jumping on this, Hiro!

Emilio, this fixes the crash and the original issue with blank PDF pages is also still fixed. I guess this falls under the "very small and well understood bracket" I was talking about. All the same, if we're to request this for b7 I wouldn't mind having your eyes/thoughts on this as an extra, after-the-fact check once you're around again.

Flags: needinfo?(emilio)

Yes, this looks good, thanks for fixing hiro.

Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
QA Whiteboard: regression, → regression, [qa-triaged]

Set release status flags based on info from the regressing bug 1662426

Comment on attachment 9173895 [details]
Bug 1663053 - Bail out from HTMLCanvasElement::CallPrintCallback is mPrintState has already destroyed. r?jwatt

Approved for 81.0b7.

Attachment #9173895 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Reproduced this issue using Firefox 82.0a1 (BuildId:20200903151816).

This issue is verified fixed using Firefox 82.0a1 (BuildId:20200906215057) and Firefox 81.0b7 (BuildId:20200906164749) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: