1663171 - [XFCE] Window manager title bar has disappeared in Nightly

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Steve]

Attachment: Screenshot_2020-09-04_07-30-55.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0

Steps to reproduce:

I opened Firefox Nightly 82.0a1 (2020-09-04) (64-bit) under XFCE4 on Ubuntu 20.04.

This just started happening with this morning's update.

Actual results:

There is no window manager tool bar/title bar.

Expected results:

There should be a title bar containing the title of the web page, the name of the application (Firefox Nightly), and some window manager controls to pin and unpin the window in workspaces, expand the window to full screen, minimize the window, and close it.

Some of these are replicated in the three controls at the extreme left of the menu bar but not the pin/unpin function. They're also in the wrong place with respect to the settings I've chosen in my window manager.

I'm attaching a screen shot showing Thunderbird's normal header and Firefox Nightly's mutated version.

I note that Google Chrome also exhibits this behavior by default but there is a setting to turn it off.

If this is going to be a "standard" setting there should be a way to revert to the original.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Alice0775 White]

I can reproduce the issue on Ubuntu20.04 with clean new profile.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aa032cbc94551a0f6e7e821d78aa0388f998e830&tochange=bb0078598fc8d05033d58cd7c8963ec14a5b3925

The good build: Browser window has titlebar.
The bad build, no titlebar and the top-left/right corner of browser are rendered with garbage triangle.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

This is intended behavior, there's whole tracker for for - Bug 1283299 :) We finally managed to make it default in Bug 1460959 there the last piece was fixed.
You can revert that in Customize -> Title bar check box in bottom left corner.
Btw. this is a standard Firefox look on Windows / MacOS too.

Comment 4

[Alice0775 White]

(In reply to Martin Stránský [:stransky] from comment #3)

This is intended behavior, there's whole tracker for for - Bug 1283299 :) We finally managed to make it default in Bug 1460959 there the last piece was fixed.
You can revert that in Customize -> Title bar check box in bottom left corner.
Btw. this is a standard Firefox look on Windows / MacOS too

However, Bug 1460959 does not fix the corner rendering issue on Ubuntu20.04.

Comment 5

[Steve]

Thank you. That works.

However, as a general comment, why can't developers make new features optional, rather than making reverting back to older behavior optional?

I hate it when an application when I depend upon suddenly starts acting in a strange manner and I have to spend a half hour or more trying to figure out whether I've broken something, inadvertently changed a configuration setting, or otherwise committed some sort of error, only to find out that some developer has decided to "help" me. I'm always happy to learn new things and adopt new technologies but not when I'm in the middle of something important.

In this case, of course, it was a rather trivial change but still. . .

Unless it's a critical change affecting security or actual usability, please make these changes optional and announce them in the appropriate manner so those who want them can adopt them.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Hi Steve, I'm sorry it causes you the troubles. Nightly is expected to come with various changes, I think we ship release notes for Beta/Release only.
Also I didn't realize that can cause any fuzz here as I always threat the enabled system titlebar on Linux/Gtk as a technical debt as it's already implemented in Firefox for MacOS/Windows ans also Chrome/Chromiun uses that by default...

Comment 7

[Steve]

Martin:

Sorry if I sounded like I was dissing Nightly -- I'm well aware that things can break and that's a risk one takes when being on the bleeding edge of things.

That being said, as a general comment, I do think that changes to UIs should be approached with caution and, if at all possible, be made in such a way that they are at the option of the user.

I used to be an user of Photoshop in a previous life and would alway dread each new version, since controls would move around and the entire workflow could change radically. A five minute image edit would turn into a 45 minute snipe hunt, trying to figure out where they've hidden some filter this time.

Believe me, developers, I like new stuff and I don't mind learning but I also like getting my work done in a timely manner. ;-)

Comment 8

[Martin Stránský [:stransky] (ni? me)]

With the Bug 1663279 the titlebar is hidden by default on KDE/Gnome only, so you should be back with system titlebar on XFCE by default.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Fixed by Bug 1663279.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1460959