1663279 - Titlebar setup misconfiguration

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Mathew Hodson]

Bug 1460959 now hides the title bar by default in more environments, but the new code ignores the level of support defined in GetSystemCSDSupportLevel().

Comment 1

[Mathew Hodson]

The if statement should be added back in HideTitlebarByDefault() at https://searchfox.org/mozilla-central/rev/dc30fc92f2d02abe716426df7eff0f0bbb907da2/widget/gtk/nsWindow.cpp#7848

if (hideTitlebar) {
  GdkScreen* screen;
  hideTitlebar = ((screen = gdk_screen_get_default()) &&
                  gdk_screen_is_composited(screen)) ||
                 TitlebarCanUseShapeMask();
}

Comment 2

[Mathew Hodson]

You should be able to test by setting env MOZ_GTK_TITLEBAR_DECORATION to none.

Expected:
Title bar is hidden by default.

Actual:
Title bar is shown by default.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Ahh, you're right! Thanks a lot.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1663279 [Linux] HideTitlebarByDefault() needs to honor GetSystemCSDSupportLevel(), r?jhorak

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1663279 [Linux] Update default titlebar configration, r?jhorak

• Use toplevel transparent window by default.
• Use Client decoration for Deepin desktop.
• Hide system titlebar by default on latest KDE versions.
• Hide system titlebar by default on Gnome/Pantheon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c500459f5539
[Linux] Update default titlebar configration, r=jhorak

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1460959

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c500459f5539