1663217 - Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp

Status: RESOLVED FIXED

(Firefox :: Installer, task, P3)

Description

[Chris Peterson [:cpeterson]]

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

BitsUtils.cpp only references MOZ_MUST_USE in a comment about forking a copy of mozilla::ScopeExit to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE from mfbt/Attributes.h). [[nodiscard]] doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1663217 - Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp. r?agashlin

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

BitsUtils.cpp only references MOZ_MUST_USE in a comment about forking a copy of mozilla::ScopeExit to remove some dependencies on other Mozilla header files (including MOZ_MUST_USE from mfbt/Attributes.h). [[nodiscard]] doesn't require a header file, so we can just remove this comment about MOZ_MUST_USE.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/326bcbd907df
Remove MOZ_MUST_USE comment from NSIS BitsUtils.cpp. r=agashlin

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/326bcbd907df