1663223 - Dark Mode: Spell check suggestions in mail compose window hard to read

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas]

Attachment: Spell checker.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36 Edg/85.0.564.44

Steps to reproduce:

Open the Mail compose windows, misspell a word and open the spell checker dialog (Options -> check spelling).

Actual results:

Suggestions for right spelling are hard to read because the font is black on dark background.

Expected results:

The font in the suggestions box should be white.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1663223-spellcheck-no-listbox-class.patch

We have to remove the theme-listbox class to work correctly with our themeable dialogs.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9174091 [details] [diff] [review]
1663223-spellcheck-no-listbox-class.patch

Review of attachment 9174091 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks, r+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0de07435990
Remove the theme-listbox class from EdSpellCheck.xhtml. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9174091 [details] [diff] [review]
1663223-spellcheck-no-listbox-class.patch

[Approval Request Comment]
User impact if declined: black text on dark background in spellcheck with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9174091 [details] [diff] [review]
1663223-spellcheck-no-listbox-class.patch

[Triage Comment]
Approved for beta
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 81.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/8b56c81e5055

Comment 7

[WaltS48 [:walts48]]

Looks good to me in testing 81.0b4 on Windows 10.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.3.0:
https://hg.mozilla.org/releases/comm-esr78/rev/391f1b69f6d6