1663237 - Replace MOZ_MUST_USE with [[nodiscard]] in mozjemalloc

Status: RESOLVED FIXED

(Core :: Memory Allocator, task, P3)

Description

[Chris Peterson [:cpeterson]]

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1663237 - Replace MOZ_MUST_USE with [[nodiscard]] in mozjemalloc. r?glandium

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

We can also stop #including mozilla/Attributes.h because it was only needed for its MOZ_MUST_USE declaration.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f84c5f5a05a
Replace MOZ_MUST_USE with [[nodiscard]] in mozjemalloc. r=glandium

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8f84c5f5a05a