1663321 - New Chat Contact doesn't work through menu or AppMenu

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

When I try to add a new Chat account through menu File/New/Chat Contact... or through AppMenu I get following error:
Uncaught Error: No connected account! addbuddy.js:24:13
onload chrome://messenger/content/chat/addbuddy.js:24
onload chrome://messenger/content/chat/addbuddy.xhtml:1
_openDialog chrome://messenger/content/chat/chat-messenger.js:1051
addBuddy chrome://messenger/content/chat/chat-messenger.js:1058
doCommand chrome://messenger/content/mail3PaneWindowCommands.js:1123
doCommand chrome://messenger/content/mailTabs.js:844
doCommand chrome://messenger/content/tabmail.js:577
goDoCommand chrome://global/content/globalOverlay.js:101
oncommand chrome://messenger/content/messenger.xhtml:1

Through Chat tab "Show Accounts" button and then "New Account" in the dialog works.

Comment 1

[Magnus Melin [:mkmelin]]

Id do get stuff in the error console (per below), but it still works for me on trunk.

TypeError: can't access property "windowGlobalChild", window is undefined
getWindowID resource://devtools/server/actors/targets/browsing-context.js:75
onWindowCreated resource://devtools/server/actors/targets/browsing-context.js:1765
makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
_fireEvent chrome://global/content/elements/wizard.js:484
set currentPage chrome://global/content/elements/wizard.js:197
advance chrome://global/content/elements/wizard.js:326
_maybeStartWizard chrome://global/content/elements/wizard.js:422
_registerPage chrome://global/content/elements/wizard.js:401
connectedCallback chrome://global/content/elements/wizard.js:500
openIMAccountWizard chrome://messenger/content/mailCore.js:648
oncommand chrome://messenger/content/messenger.xhtml:1
ThreadSafeDevToolsUtils.js:82:13
reportException resource://devtools/shared/ThreadSafeDevToolsUtils.js:82
makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:109
_fireEvent chrome://global/content/elements/wizard.js:484
set currentPage chrome://global/content/elements/wizard.js:197
advance chrome://global/content/elements/wizard.js:326
_maybeStartWizard chrome://global/content/elements/wizard.js:422
_registerPage chrome://global/content/elements/wizard.js:401
connectedCallback chrome://global/content/elements/wizard.js:500
openIMAccountWizard chrome://messenger/content/mailCore.js:648
oncommand chrome://messenger/content/messenger.xhtml:1

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1663321_fix-new-chat-contact-menu-0.patch

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9183741 [details] [diff] [review]
Bug-1663321_fix-new-chat-contact-menu-0.patch

With no chat connected there is no menuitem. Better is show it but disabled. Like this the user knows there is a menuitem for it.

When connected, the menuitem is there and I can create a contact through the main menu. But when I try through the AppMenu the item is disabled and after this the item in the main menu too. I found no way to enable it again. Only a restart of TB and connecting again the chat makes the main menuiten active again.

Comment 4

[Khushil Mistry [:khushil324]]

menuitem.disabled is not working actually, that's why I tried the hidden thing. Any idea how to solve this problem? I was facing a similar problem in any previous bug also.

Comment 5

[Khushil Mistry [:khushil324]]

We need to do something like this: https://searchfox.org/comm-central/source/calendar/lightning/content/lightning-item-panel.js#450
I will update in a while.

Comment 6

[Khushil Mistry [:khushil324]]

It's a bigger problem actually, Join Chat and Chat Status Menu items are also not working properly. I will include the fixes in the patch.

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Bug-1663321_fix-new-chat-contact-menu-1.patch

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9183974 [details] [diff] [review]
Bug-1663321_fix-new-chat-contact-menu-1.patch

Works and LGTM. Please update the reviewer in the commit message. And Maybe remove the "Fix" in it.

Comment 9

[Khushil Mistry [:khushil324]]

Attachment: Bug-1663321_fix-new-chat-contact-menu-2.patch

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc4e09c862e4
Fix Chat menuitems in Main menu and AppMenu. r=Paenglab

Comment 11

[Magnus Melin [:mkmelin]]

Is 78 affected as well? Please set the flag if it is.

Comment 12

[Magnus Melin [:mkmelin]]

Backed out: https://hg.mozilla.org/comm-central/rev/2bb484e38c6da1ea42d8313ae4192a39992f3a82
We got to be better doing try runs...

Comment 13

[Khushil Mistry [:khushil324]]

Attachment: Bug-1663321_fix-new-chat-contact-menu-3.patch

Sorry, There was a typo. I have fixed it now and successful try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=345b26e623f75ef2b236103b3b287cad95d24ef8

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/28242e5cc885
Fix Chat menuitems in Main menu and AppMenu. r=Paenglab DONTBUILD

Comment 15

[Khushil Mistry [:khushil324]]

Comment on attachment 9184162 [details] [diff] [review]
Bug-1663321_fix-new-chat-contact-menu-3.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Chat Menu Items in the menubar and AppMenu are not working correctly.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9184162 [details] [diff] [review]
Bug-1663321_fix-new-chat-contact-menu-3.patch

[Triage Comment]
Approved for beta

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 83.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/5d2b0e2d8b29

Comment 18

[WaltS48 [:walts48]]

Successfully created a chat account using File > New > Chat Account from the File Menu in my test of 83.0b3 on Windows 10.

Sorry, I didn't find this in previous testing as I was using the Account Hub buttons.

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9184162 [details] [diff] [review]
Bug-1663321_fix-new-chat-contact-menu-3.patch

[Triage Comment]
Approved for esr78

Comment 20

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/cd1286fff702

Comment 21

[WaltS48 [:walts48]]

Created Chat accounts from the Menu and App Menu.
Created Chat oontacts from the Menu and App Menu once the accounts were connected in my test of the 78.5.0 release candidate on Windows 10 (20H2).