1663346 - [PATCH] e2k is 64-bit architecture too

Status: VERIFIED FIXED

(NSS :: Build, enhancement, P3)

Description

[Michael Shigorin]

Attachment: 0001-config.gypi-e2k-is-64-bit-architecture-too.patch

Please consider applying this trivial patch adding e2k to 64-bit target architecture list (done against hg trunk).

Comment 1

[Michael Shigorin]

PS: the problem is alike to bug 1389056, build failed due to NSS_USE_64 being not set:

gcc -MMD -MF obj/lib/freebl/freeblpriv3.drbg.o.d '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DKRML_VERIFIED_UINT128 -DFREEBL_LOWHASH -DFREEBL_NO_DEPEND -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DSEED_ONLY_DEV_URANDOM -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -DSQL_MEASURE_USE_TEMP_DIR -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNDEBUG -I../../lib/freebl/mpi -I../../lib/freebl/ecl -I../../lib/freebl/verified -I../../lib/freebl/verified/kremlin/include -I../../lib/freebl/verified/kremlin/kremlib/dist/minimal -I../../lib/freebl/deprecated -I/usr/include/nspr -I/usr/src/RPM/BUILD/nss-3.55.0/dist/private/nss -I/usr/src/RPM/BUILD/nss-3.55.0/dist/public/nss -fPIC -pipe -ffunction-sections -fdata-sections -Werror -Wall -Wshadow -O2 -std=c99 -c ../../lib/freebl/drbg.c -o obj/lib/freebl/freeblpriv3.drbg.o
lcc: "/usr/include/nspr/prtypes.h", line 556: error #94: the size of an array
must be greater than zero
extern void pr_static_assert(int arg[(condition) ? 1 : -1])
^
in expansion of macro "PR_STATIC_ASSERT" at line 609 of
"../../lib/freebl/drbg.c"
PR_STATIC_ASSERT(sizeof(size_t) <= 4);
^

Comment 2

[Michael Shigorin]

PPS: the browser built with nss patched this way actually works for me.

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9174123 [details] [diff] [review]
0001-config.gypi-e2k-is-64-bit-architecture-too.patch

Review of attachment 9174123 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[J.C. Jones [:jcj] (he/they)]

Thanks for this fix! Try push in progress: https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=4767448ef85b

Comment 5

[J.C. Jones [:jcj] (he/they)]

https://hg.mozilla.org/projects/nss/rev/e524a577761d8d61ff096121a3c00bf22f2cfa94

Comment 6

[Michael Shigorin]

Thank you, JC ;-) I've verified revision 4767448ef85b to build on e2k.