Pdf content broken in print preview when toggling orientation mode
Categories
(Toolkit :: Printing, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | unaffected |
firefox80 | --- | unaffected |
firefox81 | --- | unaffected |
firefox82 | --- | fixed |
People
(Reporter: asoncutean, Assigned: emilio)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [print2020_v82][old-ui-])
Attachments
(3 files)
Affected versions
- 82.0a1 (2020-09-07)
Affected platforms
- Ubuntu 18.04
- Windows 10
- macOS 10.14
Steps to reproduce
- Launch Firefox
- Make sure print.tab_modal.enabled is set on true
- Open https://www.irs.gov/pub/irs-pdf/f1040.pdf
- Hit Ctrl + P
- Switch between Landscape and Portrait mode
Expected result
- The print preview content adjusts according to the orientation mode changing
Actual result
- The print preview content is broken
Regression range
- First bad: aa032cbc94551a0f6e7e821d78aa0388f998e830 (2020-09-03)
- Last good: 85e7a3055098f2f8f8d7abc59d7f0d6215e47984 (2020-09-02)
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=85e7a3055098f2f8f8d7abc59d7f0d6215e47984&tochange=aa032cbc94551a0f6e7e821d78aa0388f998e830
Additional notes
- Not reproducible with old ui
**Suggested severity
- S3
![]() |
||
Comment 1•4 years ago
|
||
NI Emilio so he's also aware, since he's been working on the PDF printing codepath.
![]() |
||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Note that I think the PDF content is also brokenly rendered before bug 1662914 in a different way. Before bug 1662914, the broken page is not scaled but isn't fully rendered.
Assignee | ||
Comment 3•4 years ago
|
||
Yeah, brendan can confirm, but from the code I don't think pdf.js has any way to react to the paper orientation at all. If only the new rendering should be slightly more correct.
Assignee | ||
Comment 4•4 years ago
|
||
Oh, I see what happens now. I think some code in pdf.js is not dealing with resetting the canvas state properly. So we cancel the render operation but when we re-run it it runs with old state which causes some of the weirdness I think.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 6•4 years ago
|
||
I did leave a comment in bug 1664178 comment 3 what's wrong there, FWIW.
Assignee | ||
Comment 7•4 years ago
|
||
Assignee | ||
Comment 8•4 years ago
|
||
Self-reminder to fix the issues that that PR has.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 9•4 years ago
|
||
Ryan, we need https://github.com/mozilla/pdf.js/pull/12369 in our tree to fix this and bug 1664178. Is there any chance you could take care of updating pdf.js?
Assignee | ||
Comment 10•4 years ago
|
||
(No rush, when possible... this only affects significantly the new UI)
Comment 11•4 years ago
|
||
We did one earlier today, unfortunately prior to this PR being merged upstream. It'll be in the next one some time later this week.
Comment 12•4 years ago
|
||
Marking as fixed by bug 1665812.
Comment 13•4 years ago
|
||
Description
•