1663448 - Pdf content broken in print preview when toggling orientation mode

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencast issue.gif

Affected versions

• 82.0a1 (2020-09-07)

Affected platforms

• Ubuntu 18.04
• Windows 10
• macOS 10.14

Steps to reproduce

1. Launch Firefox
2. Make sure print.tab_modal.enabled is set on true
3. Open https://www.irs.gov/pub/irs-pdf/f1040.pdf
4. Hit Ctrl + P
5. Switch between Landscape and Portrait mode

Expected result

• The print preview content adjusts according to the orientation mode changing

Actual result

• The print preview content is broken

Regression range

• First bad: aa032cbc94551a0f6e7e821d78aa0388f998e830 (2020-09-03)
• Last good: 85e7a3055098f2f8f8d7abc59d7f0d6215e47984 (2020-09-02)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=85e7a3055098f2f8f8d7abc59d7f0d6215e47984&tochange=aa032cbc94551a0f6e7e821d78aa0388f998e830

Additional notes

• Not reproducible with old ui

**Suggested severity

• S3

Comment 1

[Jonathan Watt [:jwatt]]

NI Emilio so he's also aware, since he's been working on the PDF printing codepath.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Screenshot from 2020-09-08 06-40-24.png

Note that I think the PDF content is also brokenly rendered before bug 1662914 in a different way. Before bug 1662914, the broken page is not scaled but isn't fully rendered.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah, brendan can confirm, but from the code I don't think pdf.js has any way to react to the paper orientation at all. If only the new rendering should be slightly more correct.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Oh, I see what happens now. I think some code in pdf.js is not dealing with resetting the canvas state properly. So we cancel the render operation but when we re-run it it runs with old state which causes some of the weirdness I think.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I'll try to poke at this.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

I did leave a comment in bug 1664178 comment 3 what's wrong there, FWIW.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: PDF.js PR

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Self-reminder to fix the issues that that PR has.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Ryan, we need https://github.com/mozilla/pdf.js/pull/12369 in our tree to fix this and bug 1664178. Is there any chance you could take care of updating pdf.js?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

(No rush, when possible... this only affects significantly the new UI)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

We did one earlier today, unfortunately prior to this PR being merged upstream. It'll be in the next one some time later this week.

Comment 12

[Julien Cristau [:jcristau]]

Marking as fixed by bug 1665812.

Comment 13

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1084014