1664178 - PDF documents previewed via Printer icon are not displayed correctly

Status: RESOLVED FIXED

(Core :: Print Preview, defect, P2)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: pdf995.gif

Affected versions

• 81.0b8
• 82.0a1 (2020-09-10)

Affected platforms

• Windows 10x64
• Ubuntu 18.04
• macOS 10.14

Steps to reproduce

1. Launch FF.
2. Go to http://pdf995.com/samples/pdf.pdf
3. Print preview the page via burger menu or CTRL+P
4. Close the PP modal.
5. Click on the PDF Print button.

Expected result

• Document is displayed in the same way in .js module as it is presented in Print Preview.

Actual result

• Document opened in pdf.js module displays pages randomly(sometimes inverted, sometimes zoomed in, sometimes zoomed out, etc)

Suggested Severity

• Seeing as how this issue only occurs with this specific document, I would suggest an S3

Regression range

• Will return with regression ASAP

Additional notes

• Did not manage to reproduce this issue with other pdf documents.
• This issue does not occur for the old UI.

Comment 1

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

I was unable to narrow the regression down even more than :

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4a18696ce81f949bd4fea1a68966a4e335d8fbad&tochange=5a77c0b857048d46fe4bced46b2234b49dcc84a2

I suspect 1661627 is the culprit here. Hiro, could you take a look?

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I think this is caused by the same root cause of bug 1663448.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Emilio is totally right (as in bug 1663448 comment 4).

In this pdf case, there remain stateStack when endDrawing is called from cancel().

  for (let i = this.stateStack.length; i > 0; i--) {                        
      this.restore();                                                         
  }

I've confirmed that adding above code in endDrawing fixes this case and bug 1663448, but I am totally unsure about the relationship between stateStack and this.current.activeSMask (mask operations).

Brendan, can you please take care of this bug, or tell me what the right approach to fix this bug? Thanks!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Whatever that state is restoring, this function should clear it to. Probably the transform matrix should be set to an identity.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Probably just calling ctx.resetTransform() should do.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: PDF.js PR

Comment 7

[Julien Cristau [:jcristau]]

Should be fixed by bug 1665812.

Comment 8

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1086429