1663501 - Use geolocation monitor in region.jsm

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Dale Harvey (:daleharvey)]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1653602 we added a geolocation monitor so we can access the system geolocation, we need to update Region.jsm to be able to use it

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1663501 - Use geolocation monitor for region updates r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b66d6544ad5a
Use geolocation monitor for region updates r=Standard8

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset b66d6544ad5a (bug 1663501) for payment-reporting.https.html failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=f36f3ed54672f2244b770d07bf1fd1fe55286762&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-web-platform-tests-e10s%2Cwpt5&selectedTaskRun=f6uoaGTER-i7nZ7WwyMJYg.0&tochange=9dbe57dc0d1b83ae109f84adae65b2bc8b402a5d

Backout link: https://hg.mozilla.org/integration/autoland/rev/9dbe57dc0d1b83ae109f84adae65b2bc8b402a5d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321624606&repo=autoland&lineNumber=1647

[task 2020-11-12T22:44:34.340Z] 22:44:34     INFO - TEST-START | /feature-policy/reporting/payment-reporting.https.html
[task 2020-11-12T22:44:34.347Z] 22:44:34     INFO - Closing window 21
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-PASS | /feature-policy/reporting/camera-reporting.https.html | Camera Report Format 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-PASS | /feature-policy/reporting/encrypted-media-reporting.https.html | Encrypted Media report format 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-PASS | /feature-policy/reporting/fullscreen-reporting.html | Fullscreen Report Format 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-PASS | /feature-policy/reporting/geolocation-reporting.https.html | Geolocation Report Format 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-PASS | /feature-policy/reporting/microphone-reporting.https.html | Microphone Report Format 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-PASS | /feature-policy/reporting/midi-reporting.https.html | MIDI Report Format 
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - TEST-UNEXPECTED-FAIL | /feature-policy/reporting/payment-reporting.https.html | PaymentRequest Report Format - assert_throws_dom: PaymentRequest API should not be allowed in this document. function "() => new PaymentRequest(
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO -     [{ supportedMethods: 'basic-card' }],
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO -     { total: { label: 'Total', amount: { currency: 'USD', value: 0 }}},
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO -     {}).show()" threw object "ReferenceError: PaymentRequest is not defined" that is not a DOMException SecurityError: property "code" is equal to undefined, expected 18
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - @https://web-platform.test:8443/feature-policy/reporting/payment-reporting.https.html:28:20
[task 2020-11-12T22:44:34.711Z] 22:44:34     INFO - Test.prototype.step@https://web-platform.test:8443/resources/testharness.js:2044:25
[task 2020-11-12T22:44:34.712Z] 22:44:34     INFO - Test.prototype.step_func/<@https://web-platform.test:8443/resources/testharness.js:2069:35
[task 2020-11-12T22:44:34.712Z] 22:44:34     INFO - @https://web-platform.test:8443/feature-policy/reporting/payment-reporting.https.html:34:3
[task 2020-11-12T22:44:34.861Z] 22:44:34     INFO - TEST-OK | /feature-policy/reporting/payment-reporting.https.html | took 519ms

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

The following also seems to start with the backed out changes:
https://treeherder.mozilla.org/logviewer?job_id=321627816&repo=autoland&lineNumber=2204

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:daleharvey, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Dale Harvey (:daleharvey)]

Hey, sorry I have been debugging this and trying to figure out the test failures, been tricky as I cant reproduce on a local build but can see them intermitently on try, should get to it today

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e53260a7118
Use geolocation monitor for region updates r=Standard8

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4e53260a7118