Closed Bug 1663703 Opened 1 year ago Closed 10 months ago

Perma (build specific) Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. when 82 becomes Late Beta on 2020-10-02

Categories

(Core :: Canvas: 2D, defect)

defect

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox80 --- unaffected
firefox81 --- unaffected
firefox82 --- wontfix
firefox83 --- wontfix
firefox84 - wontfix
firefox85 --- fixed

People

(Reporter: aryx, Assigned: lsalzman)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Summary: Perma Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. - assert_equals: ctx.isPointInPath(0, 0, 'nonzero') when Gecko 82 becomes Late Betaon 2020-10-02 → Perma Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. - assert_equals: ctx.isPointInPath(0, 0, 'nonzero') when 82 becomes Late Beta on 2020-10-02
Summary: Perma Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. - assert_equals: ctx.isPointInPath(0, 0, 'nonzero') when 82 becomes Late Beta on 2020-10-02 → Intermitt (build specific) Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. when 82 becomes Late Beta on 2020-10-02

Untracking as this isn't perma.

Flags: needinfo?(jcristau)
Summary: Intermitt (build specific) Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. when 82 becomes Late Beta on 2020-10-02 → Perma (build specific) Windows shippable /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. when 82 becomes Late Beta on 2020-10-02

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

Jim, this has been causing frequent failures on Win10 for the last couple cycles. Can you help find someone to look into this?

Flags: needinfo?(jcristau) → needinfo?(jmathies)
Blocks: gfx-triage
Flags: needinfo?(jmathies)

Looks like this is remote canvas related.

Flags: needinfo?(bobowencode)

I tried to bisect this, but the wpt test stopped working completely for me at some point, so that proved fruitless.
So, I then started bisecting with a cut down bit of JS.
Eventually I came to the conclusion that this has never passed (i.e. it returns true) when using PathD2D::ContainsPoint.

With remote canvas we use a PathSkia in the content process and it returns false the same as Chrome and passes.

Assuming we think that PathSkia is correct I guess we could add the check from there to the top of PathD2D::ContainsPoint.

Flags: needinfo?(bobowencode)
Flags: needinfo?(lsalzman)
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33f44696cf46
only allow PathD2D::ContainsPoint to proceed if transform is invertible. r=bobowen
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
No longer blocks: gfx-triage
Flags: needinfo?(lsalzman)
You need to log in before you can comment on or make changes to this bug.