1684050 - Intermittent build dependent TEST-UNEXPECTED-PASS | /html/canvas/element/path-objects/2d.path.isPointInStroke.scaleddashes.html | isPointInStroke() should return correct results on dashed paths at high scale factors

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[Cristina Coroiu [:ccoroiu]]

[Tracking Requested - why for this release]:

Central as beta simulation:
https://treeherder.mozilla.org/jobs?repo=try&revision=f14079f1ea3d243506b87f44b3b2b318c657404d&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows10-64-shippable%2Fopt-web-platform-tests-e10s%2Cwpt6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=325309665&repo=try&lineNumber=7157

Comment 1

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1684050 - Update expectations for 2d.path.isPointInStroke.scaleddashes.html on beta. r=aryx,jmaher

Comment 2

[Cosmin Sabou [:CosminS]]

This is unexpected pass in late beta on win devedition and shippable opt: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=f14079f1ea3d243506b87f44b3b2b318c657404d&searchStr=wpt&selectedTaskRun=ZWZyH8yNQuaVfTRHQf89XQ.0

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Similar to bug 1663703. Lee, please take a look in the new year.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 5

[Intermittent Failures Robot]

8 failures in 2956 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• mozilla-beta: 7

Platform breakdown:

• windows10-64-shippable: 5
• windows10-64-devedition: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1684050&startday=2021-01-04&endday=2021-01-10&tree=all

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This already fails for 85 late betas (8/8 on Windows 10 x64 Shippable).

Comment 7

[Lee Salzman [:lsalzman]]

Bob, does this look like something that was essentially fixed by bug 1663703, and for which we should just remove the meta file?

Comment 8

[Bob Owen (:bobowen)]

(In reply to Lee Salzman [:lsalzman] from comment #7)

Bob, does this look like something that was essentially fixed by bug 1663703, and for which we should just remove the meta file?

I thought so, which is why it fell off my radar before Christmas, but actually, this seems to be broken with remote canvas enabled and working with it disabled.
The patch from bug 1663703, doesn't affect it, so I think this requires a bit more investigation.

Comment 9

[Bob Owen (:bobowen)]

Looks like this might have been fixed on chromium by (where the test was added):
https://chromium-review.googlesource.com/c/chromium/src/+/2112955

I think that this is the important bit for us [1].

Certainly if I change [2] to the following it seems to fix it:

  float strokePrecision = sqrtf(std::max(
      (aTransform._11 * aTransform._11) + (aTransform._12 * aTransform._12),
      (aTransform._21 * aTransform._21) + (aTransform._22 * aTransform._22)));

  SkPath strokePath;
  paint.getFillPath(mPath, &strokePath, nullptr, strokePrecision);

lsalzman - what do you think?

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/graphics/path.cc;l=87-98;drc=7ccffaf0933ccc647c744bf66971bcf5f33a676a
[2] https://searchfox.org/mozilla-central/rev/07342ce09126c513540c1c343476e026cfa907bf/gfx/2d/PathSkia.cpp#141-142

Comment 10

[Lee Salzman [:lsalzman]]

Attachment: Bug 1684050 - choose appropriate stroke res scale for PathSkia::StrokeContainsPoint. r?bobowen

This uses SkDraw::ComputeResScaleForStroking to ensure we exactly match the resolution scale
that is chosen for drawing the stroked path inside the guts of Skia. This should ensure these
two don't get out of sync.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d7c420165e9
choose appropriate stroke res scale for PathSkia::StrokeContainsPoint. r=bobowen

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5d7c420165e9

Comment 13

[Alexandru Michis [:malexandru]]

Verified fixed in yesterday's central-as-late-beta simulation:
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=33b94237dfcfd44fde50c399b384ac8b7b13f8b6&test_paths=html%2Fcanvas%2Felemen&searchStr=Windows%2C10%2Cx64%2CShippable&selectedTaskRun=VpemmkvWSNmRRmTVSgovLQ.0

Comment 14

[Intermittent Failures Robot]

34 failures in 3810 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #21 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-beta: 32
• try: 1
• mozilla-release: 1

Platform breakdown:

• windows10-64-devedition: 17
• windows10-64-shippable: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1684050&startday=2021-01-11&endday=2021-01-17&tree=all

Comment 15

[Intermittent Failures Robot]

3 failures in 3488 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 3

Platform and build breakdown:

• windows10-64-shippable: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1684050&startday=2021-01-18&endday=2021-01-24&tree=all

Comment 16

[Intermittent Failures Robot]

1 failures in 3891 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform and build breakdown:

• windows10-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1684050&startday=2021-01-25&endday=2021-01-31&tree=all

Comment 17

[Intermittent Failures Robot]

2 failures in 3966 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1684050&startday=2021-02-01&endday=2021-02-07&tree=all

Comment 18

[Intermittent Failures Robot]

2 failures in 4322 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2

Platform and build breakdown:

• windows10-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1684050&startday=2021-02-08&endday=2021-02-14&tree=all