Closed
Bug 1663852
Opened 5 years ago
Closed 5 years ago
privacy.js: Identical code for different branches
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Gijs)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: coverity, regression, Whiteboard: cid 100400)
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/browser/components/preferences/privacy.js#2418-2422
This is the same code in the two branches.
Maybe it should be only
telemetryContainer.hidden = checkbox.checked;
Flags: needinfo?(emalysz)
|
Assignee | |
Comment 1•5 years ago
|
||
Coverity reads JS now?!
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(emalysz)
|
Reporter | |
Comment 2•5 years ago
|
||
Yeah but it isn't amazing. eslint is probably doing the same thing
I am just looking at the easy stuff from time to time.
I don't think we enabled it at review phase. Andi?
|
||
Comment 3•5 years ago
|
||
No ti's not enabled during review phase since during our testing, more than one year and a half ago, we found it to be pretty unreliable.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/016d89ee1114
fix identical code in both branches in the preferences, r=emalysz,preferences-reviewers,mstriemer
|
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
||
Updated•4 years ago
|
Keywords: regression
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•