1599444 - Let users know we will delete past telemetry when they opt out of data collection in about:preferences#privacy.

Status: VERIFIED FIXED

(Firefox :: Settings UI, task, P1)

Description

[chsiang]

Why:
We will let users know when they opt out of data collection in about:preferences#privacy, Firefox will also delete their data in 30 days.

What:
Update the string
Send the deletion ping when a user unticks the checkout
Add a confirmation modal

Scope:
Fast track the above work to land in en-US asap
Do L10N in later releases

Backend work will land in 72 and is tracked in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1585410

Comment 1

[chsiang]

Hi Betsy,
Do you want to link the spec you have here (either the google doc or invision)?

Comment 2

[Betsy Mikel [:betsymi]]

We can share language when it is finalized, which it is not yet. I am going to hold off putting here for now because this tends to cause confusion. Aaron's your point person for the spec.

Comment 3

[Erin Lancaster [:elan]]

[Tracking Requested - why for this release]: We need this change in Fx72.0 to correspond with: https://bugzilla.mozilla.org/show_bug.cgi?id=1585410.
:bwinton - can you take a look at this ticket and advise? Many thanks.

Comment 4

[Julien Cristau [:jcristau]]

AFAICT after bug 1585410 we send the deletion-request when the user opts out. Is making that optional really necessary right now?

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Yes, we would like this to land in 72 if possible. I suspect we might be looking at uplifting strings, which isn't the greatest, but timelines are what they are.

:jcristau - As I understand it, this bug isn't about making the deletion-request optional, but is about informing the user that that's what we're doing so that they know the full impact of unchecking that option. (Maybe we'll decouple those two things in the future, but that's a UX call for another day. 🙂)

Comment 6

[Julien Cristau [:jcristau]]

Both the title of this bug and comment 0 talk about an "option". Plus I guess as a user if I want to disable telemetry I'm not sure I'd care about the "full impact" (to mozilla), so the value of an extra modal isn't clear to me. But OK...

Comment 7

[Emma Malysz]

Attachment: Bug 1599444, allow users to delete past telemetry data within about:preferences#privacy

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cf05aa4c43c
allow users to delete past telemetry data within about:preferences#privacy r=fluent-reviewers,Gijs,flod

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9248ed2180c6
Backed out changeset 9cf05aa4c43c for causing mass browser-chrome failures CLOSED TREE

Comment 10

[Arthur Iakab [arthur_iakab]]

Backed out changeset 9cf05aa4c43c (bug 1599444) for causing mass browser-chrome failures CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/9248ed2180c6a0853827b42db34134e8635704d4

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=9cf05aa4c43cb491b7b458687f59b20c999d020a&searchStr=bc

Failure logs: bc10 - https://treeherder.mozilla.org/logviewer.html#?job_id=280056495&repo=autoland
bc3 - https://treeherder.mozilla.org/logviewer.html#?job_id=280056503&repo=autoland
bc2 - https://treeherder.mozilla.org/logviewer.html#?job_id=280054776&repo=autoland
bc1 - https://treeherder.mozilla.org/logviewer.html#?job_id=280056494&repo=autoland

Emma can you please take a look?

Comment 11

[:Gijs (he/him)]

I looked at the failure - in the markup, the button is telemetryDataDeletionLearnMoree (note extra e at the end) which means that calling document.getElementById("telemetryDataDeletionLearnMore") returns null and things are sad.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3c12a0edae4
allow users to delete past telemetry data within about:preferences#privacy r=fluent-reviewers,Gijs,flod

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e3c12a0edae4

Comment 14

[:shell escalante]

added bug that has the link for the learn more - https://bugzilla.mozilla.org/show_bug.cgi?id=1602044.

Comment 15

[Julien Cristau [:jcristau]]

Is this still targeting uplift to 72?

Comment 16

[Emma Malysz]

The correct link has been updated in Bug 1602062 and both patches have landed

Comment 17

[Julien Cristau [:jcristau]]

They've landed in mozilla-central (for 73). Comments 3 and 5 mention wanting this in 72, so we would need an uplift request ASAP if this is still part of the plan. And somehow handle l10n, e.g. by making this en-US only(?).

Comment 18

[Emma Malysz]

Attachment: Bug 1599444, allow en-US users to opt out telemetry data collection

Comment 19

[Emma Malysz]

I have a patch up currently that would make this en-US only (as I just discussed with Cindy). After review, we could uplift that patch first and then the correct SUMO link in Bug 1602062. The localization can be handled after. Gijs, does this flow sound correct?

Comment 20

[:Gijs (he/him)]

(In reply to Emma Malysz from comment #19)

I have a patch up currently that would make this en-US only (as I just discussed with Cindy). After review, we could uplift that patch first and then the correct SUMO link in Bug 1602062. The localization can be handled after. Gijs, does this flow sound correct?

I think if we want this en-US only on 72, we should inline the en-US string instead of using the ftl file, and only land that patch on beta. I posted a more complete suggestion on phab. If I've misunderstood and we also want this to be en-US only on nightly, things get more complicated (esp: what do we mean by "en-US only").

Comment 21

[Emma Malysz]

Attachment: Bug 1599444, allow users to delete past telemetry data within about:preferences#privacy r=Gijs

Comment 22

[Emma Malysz]

Comment on attachment 9117031 [details]
Bug 1599444, allow users to delete past telemetry data within about:preferences#privacy r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Shredder wouldn't be shippable.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open about:preferences#privacy in official Nightly build.

2. Tick the box that reads "Allow Firefox to send technical and interaction data to Mozilla."
3. Expected behavior: see notification box that you are now opting out of telemetry data collection and that Mozilla will remove data within 30 days.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A simple frontend only change with no other alternative.
• String changes made/needed: Hard coded in the patch

Comment 23

[Daniel Kolsis]

Verified in Nightly 73.0a1 (2019-12-22), the notification box appears as requested. Waiting for the push to be made in Beta.

Comment 24

[Julien Cristau [:jcristau]]

Comment on attachment 9117031 [details]
Bug 1599444, allow users to delete past telemetry data within about:preferences#privacy r=Gijs

approved for 72.0b11.

Comment 25

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/18136adea47c

Comment 26

[Daniel Kolsis]

Verified in Beta 73.0b2, the notification box appears as requested.