1663979 - Devtools Panel messages raw data content does not appear in dark theme mode

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Peter Magyari (Desktop QA)]

Attachment: Screenshot 2020-09-09 at 18.55.08.png

[Precondition]
Make sure "devtools.netmonitor.features.serverSentEvents" is set to 'true'

[Affected Platforms]
All

[Affected Versions]
Firefox Nightly 82.0a1
Firefox Beta 81.0b8
Firefox Release 80.0.1

[Steps To Reproduce]

1. Open Firefox
2. Navigate to: https://farooqar.github.io/sse-echo/
3. Open the Devtools Panel
4. Set the Devtools Panel to Dark theme mode
5. Select the "Network" tab (reload page if prompted)
6. Click "Connect!" on the page from Step 2
7. Click the request (Status 200) and select the "Response" tab on the right side of the panel
8. Click on a message that was sent by the server and observe the "Raw Data" content

Expected Results]
The "Raw Data" content should be dark-themed as well

[Actual Results]
The "Raw Data" content is light-themed

[Note]
This issue was introduced back when the Netmonitor still had a "Messages" tab and then it was transferred to the "Response" tab

Mozregression points to:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c9e6b5cf2987aadec4eaa74f8282437337df9908&tochange=adaf79cd55d7fc82b2c2a2b9304272f9bd8484cd

Bug 1618996 is probably the one that introduced this issue.

Harald, could you take a look?

Comment 1

[Hubert Boma Manilla (:bomsy)]

Thanks for reporting Peter!
I can reproduce it.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1663979 - Theme support for messages raw section r=honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d81d442b64f3
Theme support for messages raw section r=Honza

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d81d442b64f3

Comment 5

[Peter Magyari (Desktop QA)]

Verified fixed on Firefox 82.0a1 (20200916153738)