Closed Bug 1664001 Opened 4 years ago Closed 28 days ago

Use a "best we have" favicon choice for page-icon urls without a path

Categories

(Toolkit :: Places, defect, P3)

Product:
Toolkit
Component:
Places
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox82 --- wontfix
firefox133 --- fixed

People

(Reporter: Gijs, Assigned: yazan)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [sng][favicons-2024])

User Story

When page-icon requests a favicon for a host (no path), and we have no root icon available, we should do a fuzzier matching, where we'll pick icon from pages in that host, sorting them by frecency.
We must first of all ensure the root icon case works and is covered by tests already.

We should also file a follow-up bug to evaluate what to do for uris with paths not having an icon (should we use icon of another page under the same domain? what if that domain serves multiple services? Maybe we can exclude anything from subdomains or with querystrings?)

Attachments

(1 file)

Bug 1664001 - Fetch the icon of the subpage with the highest frecency if icon requested for a host and no root icon is available. r=#places-reviewers
48 bytes, text/x-phabricator-request
Details | Review

page-icon:https://foo.com/ will show an icon if the specific URL https://foo.com/ has been visited and we stored an icon, but not if e.g. https://foo.com/newsite/index.html has been visited.

For various usecases in the browser, it'd be useful if we could specify that we should use and/or fall back on other icons for the same site if one for the specific URL is not available.

Severity: -- → S3
Priority: -- → P2
Blocks: 323933
Blocks: 1045283
Blocks: 1412549

For various bugs and features, we need a way to extract "best you can do" favicon for origins, so this bug will cover that need.

Whiteboard: [sng]
Priority: P2 → P3

Rather than using a #ref, we can probably start from checking if the url has no path, then use a more lenient picking algorithm that will return "best we have" icon for the origin. We can use frecency.

Summary: Add a #ref parameter to `page-icon` URLs to be able to request "any [stored] icon from example.com" → Use a "best we have" favicon choice for page-icon urls without a path
Whiteboard: [sng] → [sng][favicons-2024]
Points: --- → 3
User Story: (updated)
Assignee: nobody → yalmacki
Pushed by yalmacki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4c21fa3fda6 Fetch the icon of the subpage with the highest frecency if icon requested for a host and no root icon is available. r=places-reviewers,daisuke

https://hg.mozilla.org/mozilla-central/rev/b4c21fa3fda6

Status: NEW → RESOLVED
Closed: 28 days ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Regressions: 1927173
No longer regressions: 1927173
Regressions: 1927173
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: