Closed
Bug 1664265
Opened 5 years ago
Closed 5 years ago
Default study install needs to check for Pioneer ID
Categories
(Firefox :: Pioneer, defect)
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox80 | --- | unaffected |
| firefox81 | --- | fixed |
| firefox82 | --- | fixed |
People
(Reporter: rhelmer, Assigned: rhelmer)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
|
47 bytes,
text/x-phabricator-request
|
ryanvm
:
approval-mozilla-beta+
|
Details | Review |
|
47 bytes,
text/x-phabricator-request
|
ryanvm
:
approval-mozilla-beta+
|
Details | Review |
Bug 1661803 made the default add-on check more aggressive, but it unfortunately does not double-check the Pioneer ID before re-trying default add-on install, which could cause the user to get the default add-on before enrollment.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D89806
|
||
Updated•5 years ago
|
Attachment #9174997 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D89807
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9174998 [details]
Bug 1664265 - remove errant Pioneer debugging from test r?sfoster
Beta/Release Uplift Approval Request
- User impact if declined: We made the default add-on check more aggressive, but it unfortunately does not double-check the Pioneer ID before re-trying default add-on install, which could cause the user to get the default add-on before enrollment. This bug addresses that.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Removed errant debugging from a test. Deals with about:pioneer only. No risk to Firefox.
- String changes made/needed: None
Attachment #9174998 -
Flags: approval-mozilla-beta?
|
|
||
Updated•5 years ago
|
Attachment #9175004 -
Flags: approval-mozilla-beta?
Pushed by rhelmer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f7cf952e0bb
remove errant Pioneer debugging from test r=sfoster
https://hg.mozilla.org/integration/autoland/rev/c89e73951b42
check for Pioneer enrollment before re-trying default add-on install r=maxxcrawford
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0f7cf952e0bb
https://hg.mozilla.org/mozilla-central/rev/c89e73951b42
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
|
||
Updated•5 years ago
|
Keywords: regression
|
|
||
Comment 7•5 years ago
|
||
Set release status flags based on info from the regressing bug 1661803
status-firefox80:
--- → unaffected
status-firefox81:
--- → affected
status-firefox-esr68:
--- → unaffected
status-firefox-esr78:
--- → unaffected
|
||
Comment 8•5 years ago
|
||
Comment on attachment 9174998 [details]
Bug 1664265 - remove errant Pioneer debugging from test r?sfoster
Approved for 81.0rc1.
Attachment #9174998 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Updated•5 years ago
|
Attachment #9175004 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 9•5 years ago
|
||
| bugherder uplift | ||
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•