Closed Bug 1664367 Opened 5 years ago Closed 5 years ago

78.2.2 breaks Dark Mode.

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1647931

People

(Reporter: neotitancomputing, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

Steps to reproduce:

After updating to 78.2.2, using Windows 10 Dark Mode for Apps no longer makes Thunderbird Dark Mode. Reverting to 78.2.1 by reinstalling this lower version fixes the issue.

Actual results:

Light mode turns on after updating, and the user is unable to switch to Dark Mode using the Themes option, or using the Windows 10 Dark Mode.

Expected results:

Dark Mode continues to work as expected.

Perhaps this? Bug 1661229 - Thunderbird's UI doesn't completely obey the Windows 10 high-contrast theme

Flags: needinfo?(richard.marti)
Flags: needinfo?(alessandro)

Bug 1661229 should actually cover this exact scenario, allowing TB to follow the OS theme.
I'll try to reproduce the issue.

Flags: needinfo?(alessandro)

This works for me. But I need to restart TB most of the times to apply the system theme or first apply the other theme, corresponding to the system theme and then apply the default theme. When starting TB with the default theme it picks up the correct theme.

Flags: needinfo?(richard.marti)

It works as expected for me.
The workflow is to have:

  • Set Thunderbird with default Theme.
  • Close Thunderbird.
  • Set Windows system Dark Mode.
  • Launch Thunderbird.

With this, Thunderbird respects Windows system theme.
neotitancomputing, could you give it a try?

Flags: needinfo?(neotitancomputing)

I already use Dark Mode for all my other Apps, and this solution above does not fix.

The problem is somehow resolved simply by re-installing 78.2.1 on top of 78.2.2, so there's some file change that breaks the ability.

As you can see here, this is the view for 78.2.1. Forgive the blurring.:

https://prnt.sc/ufct79

Straight after doing an install for 78.2.2:

https://prnt.sc/ufcul1

Then simply close TB and reinstall 78.2.1:

https://prnt.sc/ufcv8f

No changes to themes, settings, or anything between these screenshots. All I do is upgrade and rollback the install version. My windows contrast settings do not change between these. Set to dark mode the entire time.

https://prnt.sc/ufcvpl

Flags: needinfo?(neotitancomputing)

Is your Thunderbird Theme set to "Default"?

Correct.

When I attempt to change it to any other theme, the "enable" buttons do nothing when clicked. They just say "disabled".

Can you check in the error console (CTRL+SHIFT+J) if you see the error from bug 1647931 comment 0 when you try to switch the themes?

Interesting.

I am indeed getting:

Uncaught (in promise) TypeError: addon.userPermissions is null
shouldShowPermissionsPrompt chrome://mozapps/content/extensions/aboutaddonsCommon.js:156
handleEvent chrome://mozapps/content/extensions/aboutaddons.js:2814

This error seems to happen on 78.2.1 and 78.2.2 as well.

However, as stated, 78.2.2 is the only one where it actually causes theme issues.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.