1664418 - Crash in [@ encoding_rs::utf_8::Utf8Decoder::decode_to_utf16_raw]

Status: NEW

(Core :: Gecko Profiler, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/e02b88f3-c758-4d4d-9072-bfd7b0200911

Top 10 frames of crashing thread:

0 xul.dll encoding_rs::utf_8::Utf8Decoder::decode_to_utf16_raw third_party/rust/encoding_rs/src/utf_8.rs:506
1 xul.dll encoding_rs::mem::convert_utf8_to_utf16 third_party/rust/encoding_rs/src/mem.rs:1482
2 xul.dll nsstring::conversions::nsstring_fallible_append_utf8_impl xpcom/rust/nsstring/src/conversions.rs:691
3 xul.dll NS_ConvertUTF8toUTF16::NS_ConvertUTF8toUTF16 xpcom/string/nsString.h:115
4 xul.dll static SharedLibraryInfo::GetInfoForSelf tools/profiler/core/shared-libraries-win32.cc:224
5 xul.dll mozilla::Telemetry::BatchProcessedStackGenerator::BatchProcessedStackGenerator toolkit/components/telemetry/other/ProcessedStack.cpp:72
6 xul.dll mozilla::UntrustedModulesProcessor::ProcessModuleLoadQueue toolkit/xre/UntrustedModulesProcessor.cpp:601
7 xul.dll mozilla::UntrustedModulesProcessor::BackgroundProcessModuleLoadQueue toolkit/xre/UntrustedModulesProcessor.cpp:479
8 xul.dll mozilla::detail::RunnableMethodImpl< xpcom/threads/nsThreadUtils.h:1240
9 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1242

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Quick thoughts:

• Are we reading outside of the library (this could be tested)?
• Is this related to the "SharedLibraryInfo::GetInfoForSelf" signature? (In which this decode_to_utf16_raw happens.) Looking near the top of old bug 1342349, the graph for that signature seems to have started around early May. The only change to that file around that time is bug 1635823, though at a glance it would seem unlikely to have caused all these crashes(?)

To be investigated...