166471 - nsIFind can return bogus ranges

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Aaron Leventhal]

If the search range used with nsIFind coverse the entire document, nsIFind can
return bogus ranges where the start and/or end container is null.

There are multiple problems here:
1. nsIFind::Find does not check the return values for range SetStart or SetEnd
2. nsIFind should be skipping over all comment nodes, but it doesn't appear to
be when they're before the <head>.

Test case is the same as for bug 166340, when the fix for that bug is reversed.

The only reason this hasn't been a problem so far is becase nsWebBrowserFind
uses GetBody(). However, I don't think GetBody() will work with xml content
documents.

Comment 1

[Akkana Peck]

Attachment: test case (search for l gets lost, search for q succeeds

Apparently layout is treating those comments outside the <html> tag differently
from normal comments inside the body, and SkipNode isn't catching them.

Comment 2

[Akkana Peck]

Attachment: Add some error checking

The test cases no longer demonstrates anything, since aaron has worked around
this, but more error checking is still a good idea.  So here it is.  Aaron, can
you review?

Comment 3

[Aaron Leventhal]

Akkana, this fixes the problem of the bogus ranges, but should we find out why
the nsFind code sometimes searches comment nodes? The test case in bug 175046
shows that.

Comment 4

[Aaron Leventhal]

.

Comment 5

[Aaron Leventhal]

checked in with fix for bug 175046.

Comment 6

[sairuh (rarely reading bugmail)]

the test case appears fine with 2003.01.08.08 on linux rh8.