1664721 - Thunderbird 78.2.2 broken if built without updater

Status: RESOLVED DUPLICATE of bug 1664607

(Thunderbird :: Build Config, defect)

Description

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/5.15.1 Chrome/80.0.3987.163 Safari/537.36

Steps to reproduce:

Build thunderbird from source with --disable-updater and run it.

Actual results:

Window opens but nothing works. Following error is logged in terminal:

JavaScript error: chrome://messenger/content/specialTabs.js, line 1051: TypeError: Cc['@mozilla.org/updates/update-manager;1'] is undefined
console.log: (new Error("Cannot load required OTR library", "resource:///modules/OTRLib.jsm", 75))

related code:

let update = Cc["@mozilla.org/updates/update-manager;1"].getService(
  Ci.nsIUpdateManager
).activeUpdate;

I believe it was added in bug 1563411

Expected results:

specialTabs.js should check if updater is available first and thunderbird should work fine. Note that workaround with just adding condition on AppConstants.MOS_UPDATER makes thunderbird work again

let update = AppConstants.MOZ_UPDATER && Cc["@mozilla.org/updates/update-manager;1"].getService(
  Ci.nsIUpdateManager
).activeUpdate;

Though looking at other places making use of update-manager service it should be more sophisticated.