166481 - Spellcheck is borked.

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Matthew Tuck [:CodeMachine]]

Spellcheck needs updates.

Firstly, I wanted to add new words:

paramater (parameter) (I saw this in a patch somewhere)
existance (existence) (common)
existant (existent)

When I tested this, I discovered that spellcheck wasn't finding these
misspellings.  As it happens, only the first misspelling in the list is
successfully located.  This seems to be because the file isn't being reopened
between the misspellings.

Furthermore, spellcheck should check every file in the CVS tree for
misspellings, including the documentation, not just Perl scripts.  You can
exclude data and graphs, but everything else is fair game really.

Comment 1

[Matthew Tuck [:CodeMachine]]

Also $found_word isn't initialised first time through so I got uninit errors.

Comment 2

[Matthew Tuck [:CodeMachine]]

Attachment: Adds new words and fixes bugs.

Here's a fix to the uninit variable and lack of reopening.  It will break tbox
so the spelling errors need to be corrected first.

It doesn't yet make the test check all files.

Comment 3

[Zach Lipton [:zach]]

Attachment: Fix the spelling errors so tinderbox doesn't go up in flames

Comment 4

[Zach Lipton [:zach]]

*** Bug 162224 has been marked as a duplicate of this bug. ***

Comment 5

[Dave Miller [:justdave]]

zach: ping.  This was approved for checkin a week ago.  Hope it hasn't bitrotted :)

Comment 6

[Zach Lipton [:zach]]

never! with my advanced project management methods, my patches never go stale!

Fix checked in (both patches)