1664814 - Keyword search containing long HTML code will crash Firefox

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Thomas Deutschmann]

Attachment: bookmark_w_keyword.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

1. Create a bookmark and assign a keyword (see attached screenshot).

2. Now type "<keyword>[SPACE]<Paste HTML code>

Actual results:

Firefox will become unresponsive and needs to be killed.

Expected results:

Of course pasting such a content was a mistake. However, Firefox shouldn't become unresponsive.

(This happened when I copied something from Twitter.com while web development tools where opened. So I copied the complete HTML instead of the selected word).

Comment 1

[Thomas Deutschmann]

Attachment: firefox_not_responding.png

Comment 2

[Thomas Deutschmann]

Attachment: html_code.txt

Comment 3

[Andrei Purice]

Hey Thomas,
I tried to reproduce this on the latest Nightly 82.0a1 (2020-09-17), beta 81.0 and release 80.0.1 but i can add the html code and firefox won't freeze.

Can you test the issue while in Safe Mode. You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .

Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .

If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 4

[Thomas Deutschmann]

Attachment: ff_kws_freeze.webm

I am also able to reproduce with current Firefox Nightly on Windows. Even on Linux, see the following screencast.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I can repro. I took a profile using perf (because I can't stop the native profiler as the main thread is hung up), and all of the time seems spent in js::intl_CompareStrings.

Looking at the callers of that Intl.Collator and String.localeCompare, I suspect we're hanging around here in the URL bar code.

Comment 7

[Marco Bonardo [:mak]]

we should be limiting our lookup to a subset of the string.
other related bugs: Bug 1622321, Bug 1589602

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1664814: Stop to use regex that identifies string that is uri like.

Comment 9

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1664814: Limit the number of tokens to reduce calculate time.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0822a4287a75
Limit the number of tokens to reduce calculate time. r=adw

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0822a4287a75

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/df4b0f1795ad

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

I've managed to reproduce the issue using a Fx nightly build from 08-04-2020. Please note that the issue does not occur on high end machines (Firefox does lose performance, but never fully hangs).

The issue is verified fixed in Fx93.0a1 on Windows 10 and Ubuntu 20.04. Firefox no longer hangs after pasting the HTML code in the address bar.