Closed Bug 1726837 Opened 2 years ago Closed 2 years ago

Remove unnecessary loop over tokens in splitString() in UrlbarTokenizer.jsm

Categories

(Firefox :: Address Bar, task, P3)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox93 --- fixed

People

(Reporter: adw, Assigned: daisuke)

References

Details

(Keywords: perf)

Attachments

(1 file)

Bug 1726837: Refactoring for splitString function.
48 bytes, text/x-phabricator-request
Details | Review

This loop iterates over every token, but as currently written, all it does is special-case the first and last tokens and push every other token in between onto an array. There's no need for that. Instead it can use the tokens array as initialized and handle the first and last tokens as necessary, potentially replacing them with with two tokens each, the restriction token + remainder.

This is spun out from bug 1664814 and Daisuke's investigation in D123043.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f79cc68cd2fe
Refactoring for splitString function. r=adw

https://hg.mozilla.org/mozilla-central/rev/f79cc68cd2fe

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox93: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.