1664829 - AboutDialog - download start number remains 0 - it is not incremented to max in Nightly

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Michael Wolf]

HI,

in Nightly aboutDialog dialog (Help --> About Nightly) the start download number is not incremented from 0 to the maximum number during the update progress, e.g.

Downloading update — 0 from 6.9 MB

remains unchanged until the "Restart to Update" button is displayed.

Expected: Download number should be incremented, e.g. 1.0 from 6.9 MB, 2.0 from 6.9, etc.

Unfortunately, I couldn't catch the right moment to take a screenshot.

Comment 1

[Viktor Jägersküpper]

Just tested manually:
Nightly 2020-09-02-09-53-59 is the last good release (without this bug), 2020-09-02-21-57-21 is the first bad release.

Comment 2

[Viktor Jägersküpper]

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b74ab1682deaf69e9d0eac0fb9c29e7e7a5a7a0b&tochange=85e7a3055098f2f8f8d7abc59d7f0d6215e47984

Maybe bug 1600864?

Comment 3

[Alin Ilea, Desktop Test Engineering [pto until 01.09]]

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b74ab1682deaf69e9d0eac0fb9c29e7e7a5a7a0b&tochange=85e7a3055098f2f8f8d7abc59d7f0d6215e47984

Maybe bug 1600864?

Hi, after performing mozregression I got the same result as the one above.
Drew, could you take a look over this?
Thanks.

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8847ff01702bfe15f1d63c325a1bbdd04c310a2d

Comment 5

[Drew Willcoxon :adw]

Attachment: Bug 1664829 - Add nsIProgressEventSink to AppUpdater so that download progress is correctly reported again.

AppUpdater just needs to declare that it implements nsIProgressEventSink.
nsIProgressEventSink.onProgress is the method that's called whenever download
progress is made, and AppUpdater implements it, but the caller doesn't call it
because it checks that consumers are instanceof nsIProgressEventSink:
https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/UpdateService.jsm#5014

I've updated all the updater tests (via their head.js) so that they check the
download progress text. This applies to about-dialog and about:preferences
tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d6c2379b011
Add nsIProgressEventSink to AppUpdater so that download progress is correctly reported again. r=bytesized

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1d6c2379b011

Comment 9

[Alin Ilea, Desktop Test Engineering [pto until 01.09]]

Verified - Fixed in Nightly 82.0a1 (2020-09-19) build id: 20200919212721. The downloading progress in displayed. Verified on Win10 and Ubuntu 18.04.