Closed Bug 1664867 Opened 4 years ago Closed 4 years ago

Add tests to confirm that we select the right video when using the keyboard shortcut for PiP

Tracking

()

Status:

RESOLVED FIXED

Milestone:

83 Branch

Tracking Flags:

Tracking

Status

firefox83

---

fixed

People

(Reporter: jaws, Assigned: jack1391)

References

Details

Attachments

(1 file)

Bug 1664867 - Add tests to confirm that the correct video is selected when using the keyboard shortcut for Picture-in-Picture. r?mconley,gijs 4 years ago Chris Jackson 47 bytes, text/x-phabricator-request		Details \| Review

Jared Wein [:jaws] (please needinfo? me)

Reporter

Description

•

4 years ago

This is a follow-up from bug 1661061.

See https://searchfox.org/mozilla-central/rev/0c97a6410ff018c22e65a0cbe4e5f2ca4581b22e/toolkit/actors/PictureInPictureChild.jsm#1578 for the code that selects a video.

Mike Conley (:mconley) (:⚙️)

Comment 1

•

4 years ago

Hey Chris,

Take a look at what we did in bug 1661061. We changed the heuristics of what video is selected when we use the keyboard shortcut to launch Picture-in-Picture, and this bug is about writing a test for those heuristics. Let me know if you have questions!

Assignee: nobody → jack1391

Chris Jackson

Assignee

Comment 2

•

4 years ago

Attached file Bug 1664867 - Add tests to confirm that the correct video is selected when using the keyboard shortcut for Picture-in-Picture. r?mconley,gijs — Details

Pulsebot

Comment 3

•

4 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/decb61273068
Add tests to confirm that the correct video is selected when using the keyboard shortcut for Picture-in-Picture. r=Gijs

Bogdan Tara[:bogdan_tara | bogdant]

Comment 4

•

4 years ago

Backed out changeset decb61273068 (bug 1664867) for toolkit/components/pictureinpicture/tests failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=ZE4w80u4TRK2psiuzc7vXQ.0&fromchange=1f1d6d98b18a2a00994e8549046d7d7bae501e29&searchStr=mochitest-browser-chrome&tochange=bb508d4f63d96027b87e4b427f247c5d22294abc

Backout link: https://hg.mozilla.org/integration/autoland/rev/bb508d4f63d96027b87e4b427f247c5d22294abc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316934985&repo=autoland&lineNumber=10745

[task 2020-09-28T18:09:19.427Z] 18:09:19     INFO - TEST-START | toolkit/components/pictureinpicture/tests/browser_toggleMode_1.js
[task 2020-09-28T18:09:19.505Z] 18:09:19     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fbb3c660c00 == 2 [pid = 6263] [id = 34]
[task 2020-09-28T18:09:19.505Z] 18:09:19     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x7fbb477e5b70) [pid = 6263] [serial = 80] [outer = (nil)]
[task 2020-09-28T18:09:19.505Z] 18:09:19     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (0x7fbb3c664000) [pid = 6263] [serial = 81] [outer = 0x7fbb477e5b70]
[task 2020-09-28T18:09:19.614Z] 18:09:19     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 10 (0x7fbb3c6e9800) [pid = 6263] [serial = 82] [outer = 0x7fbb477e5b70]
[task 2020-09-28T18:09:20.540Z] 18:09:20     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7fbb3c663c00) [pid = 6263] [serial = 72] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:20.541Z] 18:09:20     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fbb3c662400 == 1 [pid = 6263] [id = 33] [url = about:blank]
[task 2020-09-28T18:09:20.628Z] 18:09:20     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7fbb477e69f0) [pid = 6263] [serial = 73] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page-with-sound.html]
[task 2020-09-28T18:09:20.629Z] 18:09:20     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7fbb477e6480) [pid = 6263] [serial = 76] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.106Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f15ebf06c00 == 6 [pid = 6118] [id = 37] [url = chrome://global/content/pictureinpicture/player.xhtml]
[task 2020-09-28T18:09:21.107Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f15ebf0f800 == 5 [pid = 6118] [id = 38] [url = chrome://global/content/pictureinpicture/player.xhtml]
[task 2020-09-28T18:09:21.108Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 25 (0x7f15f81aec00) [pid = 6118] [serial = 47] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.109Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 24 (0x7f15f0fb5400) [pid = 6118] [serial = 45] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.109Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 23 (0x7f15ed6bfc00) [pid = 6118] [serial = 67] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.110Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 22 (0x7f15fba51800) [pid = 6118] [serial = 49] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.110Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 21 (0x7f15f66d8400) [pid = 6118] [serial = 55] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.110Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 20 (0x7f15f0fadc00) [pid = 6118] [serial = 69] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.111Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 19 (0x7f1602487800) [pid = 6118] [serial = 51] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.111Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 18 (0x7f15ecb40000) [pid = 6118] [serial = 43] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.111Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (0x7f15ed6c7800) [pid = 6118] [serial = 73] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.112Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (0x7f15ebb30000) [pid = 6118] [serial = 71] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:21.363Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (0x7f15ec72b870) [pid = 6118] [serial = 74] [outer = (nil)] [url = chrome://global/content/pictureinpicture/player.xhtml]
[task 2020-09-28T18:09:21.363Z] 18:09:21     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x7f15ec72c350) [pid = 6118] [serial = 76] [outer = (nil)] [url = chrome://global/content/pictureinpicture/player.xhtml]
[task 2020-09-28T18:09:22.334Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fcd69ee5400 == 2 [pid = 6421] [id = 43] [url = http://example.org/browser/toolkit/components/pictureinpicture/tests/test-page-with-iframe.html]
[task 2020-09-28T18:09:22.335Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fcd74752c00 == 1 [pid = 6421] [id = 44] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html]
[task 2020-09-28T18:09:22.336Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (0x7fcd69ef0c00) [pid = 6421] [serial = 96] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.336Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (0x7fcd69eeb000) [pid = 6421] [serial = 100] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.336Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (0x7fcd69eed400) [pid = 6421] [serial = 103] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.337Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7fcd69ee8800 == 0 [pid = 6421] [id = 45] [url = about:blank]
[task 2020-09-28T18:09:22.413Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x7fcd75bb5480) [pid = 6421] [serial = 102] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html]
[task 2020-09-28T18:09:22.413Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7fcd75bb5650) [pid = 6421] [serial = 93] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.413Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7fcd75bb4f10) [pid = 6421] [serial = 97] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.414Z] 18:09:22     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7fcd75bb5d90) [pid = 6421] [serial = 90] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html]
[task 2020-09-28T18:09:22.779Z] 18:09:22     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7f4fd6a0bc00) [pid = 6373] [serial = 61] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.780Z] 18:09:22     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (0x7f4fd6a0e000) [pid = 6373] [serial = 63] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.782Z] 18:09:22     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (0x7f4fd7516400) [pid = 6373] [serial = 69] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html]
[task 2020-09-28T18:09:22.782Z] 18:09:22     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f4fd6a0d000 == 1 [pid = 6373] [id = 32] [url = about:blank]
[task 2020-09-28T18:09:22.822Z] 18:09:22     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7f4fe27ab820) [pid = 6373] [serial = 70] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:22.823Z] 18:09:22     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7f4fe27ab480) [pid = 6373] [serial = 64] [outer = (nil)] [url = http://example.org/browser/toolkit/components/pictureinpicture/tests/test-page-with-iframe.html]
[task 2020-09-28T18:09:24.626Z] 18:09:24     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7fbb3ca03c00) [pid = 6263] [serial = 75] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page-with-sound.html]
[task 2020-09-28T18:09:24.626Z] 18:09:24     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7fbb3c664000) [pid = 6263] [serial = 81] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:24.626Z] 18:09:24     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7fbb3c661400) [pid = 6263] [serial = 77] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:24.670Z] 18:09:24     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7fbb477e6650) [pid = 6263] [serial = 78] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:25.420Z] 18:09:25     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (0x7f15ec241000) [pid = 6118] [serial = 75] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:25.421Z] 18:09:25     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (0x7f15ebf0d400) [pid = 6118] [serial = 77] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:25.618Z] 18:09:25     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (0x7f15ec72bde0) [pid = 6118] [serial = 78] [outer = (nil)] [url = chrome://global/content/pictureinpicture/player.xhtml]
[task 2020-09-28T18:09:26.336Z] 18:09:26     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7fbb3c664c00) [pid = 6263] [serial = 79] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:26.477Z] 18:09:26     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x7fcd69eebc00) [pid = 6421] [serial = 94] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:26.478Z] 18:09:26     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (0x7fcd6962d400) [pid = 6421] [serial = 98] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:26.479Z] 18:09:26     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7fcd7475b000) [pid = 6421] [serial = 92] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html]
[task 2020-09-28T18:09:26.479Z] 18:09:26     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7fcd7475e000) [pid = 6421] [serial = 104] [outer = (nil)] [url = http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html]
[task 2020-09-28T18:09:26.519Z] 18:09:26     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7fcd75bb5820) [pid = 6421] [serial = 105] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:26.520Z] 18:09:26     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7fcd75bb52b0) [pid = 6421] [serial = 99] [outer = (nil)] [url = http://example.org/browser/toolkit/components/pictureinpicture/tests/test-page-with-iframe.html]
[task 2020-09-28T18:09:26.861Z] 18:09:26     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f4fd7109800) [pid = 6373] [serial = 66] [outer = (nil)] [url = http://example.org/browser/toolkit/components/pictureinpicture/tests/test-page-with-iframe.html]
[task 2020-09-28T18:09:26.862Z] 18:09:26     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f4fd7109000) [pid = 6373] [serial = 71] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:26.897Z] 18:09:26     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7f4fe27ab0e0) [pid = 6373] [serial = 72] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:28.343Z] 18:09:28     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (0x7fcd6ac3f000) [pid = 6421] [serial = 101] [outer = (nil)] [url = http://example.org/browser/toolkit/components/pictureinpicture/tests/test-page-with-iframe.html]
[task 2020-09-28T18:09:28.343Z] 18:09:28     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (0x7fcd69eea400) [pid = 6421] [serial = 106] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:29.704Z] 18:09:29     INFO - GECKO(6118) | [Parent 6118: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (0x7f15ec23d000) [pid = 6118] [serial = 79] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:09:30.956Z] 18:09:30     INFO - GECKO(6118) | [Child 6373: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (0x7f4fd6a0f400) [pid = 6373] [serial = 73] [outer = (nil)] [url = about:blank]
[task 2020-09-28T18:10:49.427Z] 18:10:49     INFO - TEST-INFO | started process screentopng
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - TEST-INFO | screentopng: exit 0
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - Buffered messages logged at 18:09:19
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - Entering test bound 
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - Buffered messages logged at 18:09:20
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - Waiting for videos to be ready
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - Buffered messages finished
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleMode_1.js | Test timed out - 
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - GECKO(6118) | MEMORY STAT | vsize 3595MB | residentFast 349MB | heapAllocated 94MB
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - TEST-OK | toolkit/components/pictureinpicture/tests/browser_toggleMode_1.js | took 90030ms
[task 2020-09-28T18:10:50.123Z] 18:10:50     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-09-28T18:10:50.124Z] 18:10:50     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleMode_1.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html - 
[task 2020-09-28T18:10:50.124Z] 18:10:50     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fcd69622800 == 1 [pid = 6421] [id = 46]
[task 2020-09-28T18:10:50.124Z] 18:10:50     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (0x7fcd75bb4f10) [pid = 6421] [serial = 107] [outer = (nil)]
[task 2020-09-28T18:10:50.124Z] 18:10:50     INFO - GECKO(6118) | [Child 6421: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (0x7fcd69626800) [pid = 6421] [serial = 108] [outer = 0x7fcd75bb4f10]
[task 2020-09-28T18:10:50.124Z] 18:10:50     INFO - checking window state
[task 2020-09-28T18:10:50.124Z] 18:10:50     INFO - TEST-START | toolkit/components/pictureinpicture/tests/browser_toggleMode_2.js
[task 2020-09-28T18:10:50.125Z] 18:10:50     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-09-28T18:10:50.125Z] 18:10:50     INFO - Buffered messages logged at 18:10:49
[task 2020-09-28T18:10:50.125Z] 18:10:50     INFO - Entering test bound 
[task 2020-09-28T18:10:50.125Z] 18:10:50     INFO - Buffered messages finished
[task 2020-09-28T18:10:50.129Z] 18:10:50     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleMode_1.js | Uncaught exception received from previously timed out test - AbortError: Actor 'SpecialPowers' destroyed before query 'Spawn' was resolved
[task 2020-09-28T18:10:50.129Z] 18:10:50     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7fbb3c662400 == 2 [pid = 6263] [id = 35]
[task 2020-09-28T18:10:50.129Z] 18:10:50     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x7fbb477e6480) [pid = 6263] [serial = 83] [outer = (nil)]
[task 2020-09-28T18:10:50.129Z] 18:10:50     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7fbb3c664000) [pid = 6263] [serial = 84] [outer = 0x7fbb477e6480]
[task 2020-09-28T18:10:50.132Z] 18:10:50     INFO - GECKO(6118) | [Child 6263: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7fbb3c6e7800) [pid = 6263] [serial = 85] [outer = 0x7fbb477e6480]
[task 2020-09-28T18:10:50.273Z] 18:10:50     INFO - Waiting for videos to be ready
[task 2020-09-28T18:10:50.301Z] 18:10:50     INFO - Testing video with id: with-controls
[task 2020-09-28T18:10:50.429Z] 18:10:50     INFO - Checking toggle policy
[task 2020-09-28T18:10:50.545Z] 18:10:50     INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleMode_2.js | No toggle policy should be set. - true == true - 
[task 2020-09-28T18:10:50.546Z] 18:10:50     INFO - Waiting for toggle to become visible
...

Flags: needinfo?(jack1391)

:Gijs (he/him)

Updated

•

4 years ago

Comment 5

•

4 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c4cacc17428f
Add tests to confirm that the correct video is selected when using the keyboard shortcut for Picture-in-Picture. r=Gijs

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

4 years ago

Regressions: 1668725

Andreea Pavel [:apavel]

Comment 6

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/c4cacc17428f

Status: NEW → RESOLVED

Closed: 4 years ago

status-firefox83: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 83 Branch

Chris Jackson

Assignee

Updated

•

4 years ago

Flags: needinfo?(jack1391)

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Add tests to confirm that we select the right video when using the keyboard shortcut for PiP

Categories

(Toolkit :: Video/Audio Controls, task, P3)

Tracking

()

People

(Reporter: jaws, Assigned: jack1391)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Updated

Comment 5

Updated

Comment 6

Updated

Attachment

General

Description

File Name

Content Type