1664888 - Update pdf.js to version 2.7.53

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1664190 +++

Changes since last update:
#12365 Ensure that the length property won't be accidentally accessed on a DecodeStream-instance
#12363 canvas: Properly restore all the remaining items in stateStack in endDrawing
#12368 Revert "canvas: Properly restore all the remaining items in stateStack in endDrawing"
#12372 Skip failing FBF tests, when running makeref, in Firefox as well
#12374 Replace \n and \r by \n and \r when saving a string

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1664888 - Update pdf.js to version 2.7.53. r=bdahl

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1664888 - Replace \n and \r by \n and \r when saving a string. r=bdahl

This is a cherry-pick of the following upstream commit:
https://github.com/mozilla/pdf.js/pull/12374

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Try pushes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=63e423cdf4beef5b4005f9004979eb044f28495e (m-c 2.7.53 update)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c40cac4612926f315b984800fcc4f9e198fc351 (cherry-pick for 81)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb49606f619e
Update pdf.js to version 2.7.53. r=bdahl

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 9175602 [details]
Bug 1664888 - Replace \n and \r by \n and \r when saving a string. r=bdahl

Beta/Release Uplift Approval Request

• User impact if declined: When a user saves some PDF forms the checkbox values will not show correctly when opened in adobe acrobat.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://github.com/mozilla/pdf.js/issues/12373
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change to PDF creation code.
• String changes made/needed:

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/eb49606f619e

Comment 7

[Bogdan Maris, Desktop QA]

Verified that using latest Nightly the checkboxes are properly displayed in Acrobat, and others, also checked for regressions and found no issues. Leaving qe-verify+ and the status of the bug as they are since an uplift to 81.0 will be required.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9175602 [details]
Bug 1664888 - Replace \n and \r by \n and \r when saving a string. r=bdahl

Thanks for verifying. Approved for 81.0rc2.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/e3ab59ff6368

Comment 10

[Bogdan Maris, Desktop QA]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #7)

Verified that using latest Nightly the checkboxes are properly displayed in Acrobat, and others, also checked for regressions and found no issues. Leaving qe-verify+ and the status of the bug as they are since an uplift to 81.0 will be required.

Also verified using release build from treeherder that contains this fix across platforms.