1664952 - There is no pointer Lock warning shown while requesting lock on an iframe

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Edgar Chen [:edgar]]

Attachment: pointer_lock.html

Similar to bug 1580506, but happens on iframe.

STR:
Click on the canvas area inside the iframe (the element with a blue border).

Actual Result:
We should see a warning showing up that the website has taken control of your cursor and you can get it back, but it doesn't show up.

Expected Result:
No warning showing up.

Comment 1

[Edgar Chen [:edgar]]

Regression window: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=222e9db6edde5da6401c4894ea7b9ba3376434a8&tochange=43b2d57b25cc16d0571e6bef6a414abe24457154

This might be a regression of bug 1533948. Neil, can you please take a look at this bug? Thanks.

Comment 2

[Neil Deakin]

Attachment: Bug 1664952, move the pointer lock warning handling into a separate actor that applies to subframes, and move origin determination into parent, r=gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4548a773cf08
move the pointer lock warning handling into a separate actor that applies to subframes, and move origin determination into parent, r=Gijs

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4548a773cf08

Comment 5

[Timea Cernea [:tbabos][inactive]]

Reproduced the issue on affected Beta 82.0b2.
Verified-fixed on latest Beta 83.0b2 and latest Nightly 84.0a1 (2020-10-20) (64-bit) on Windows 10, macOS 10.15 and Ubuntu 16.04.
The warning will be shown for the users to be aware of the site taking control of the cursor.