1533948 - [Fission] Make BrowserTabChild ready for Fission

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

Make the code in BrowserTabChild.jsm ready to work with out-of-process iframes

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1533948 - Set up new structure for actors vs. legacy actors.

Original patch by Mike Conley from another bug. Cleaned it up and incorporated here

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1533948 - Set up new BrowserTab Parent/Child actors.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1533948 - Port DOMWindowCreated to the new actor

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1533948 - Port first MozAfterPaint to the new actor

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1533948 - Port PointerLock to the new actor

Comment 6

[:Felipe Gomes (needinfo for replies!)]

So what I did to help the conversion was to make a copy of BrowserTabChild and call it BrowserTabChild2.jsm. That way, I could be porting part of the features to the new actor, while keep the remaining ones working through the legacy actor.

The patch queue ported all the functionality going from the child to parent. There are some comments that I left that are good gotchas to be aware of, and probably should be filed as bugs for improvements on the API.

Comment 7

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Hey Neil, are you okay to pick this one up from Felipe?

Comment 8

[Neil Deakin]

I think I have figured out what to do here.

Comment 9

[Neil Deakin]

Attachment: Bug 1533948, add new BrowserTab Parent/Child actors

Comment 10

[Neil Deakin]

Attachment: Bug 1533948, Port DOMWindowCreated to the new actor

Depends on D30030

Comment 11

[Neil Deakin]

Attachment: Bug 1533948, Port first MozAfterPaint to the new actor

Depends on D30032

Comment 12

[Neil Deakin]

Attachment: Bug 1533948, Port PointerLock to the new actor

Depends on D30034

Comment 13

[Neil Deakin]

Attachment: Bug 1533948, remove unused AllowScriptsToClose message from BrowserTab actor

Depends on D30037

Comment 14

[Neil Deakin]

Attachment: Bug 1533948, port Browser:Reload message to the new BrowserTab actor

Depends on D30040

Comment 15

[Neil Deakin]

Attachment: Bug 1533948, port Browser:AppTab message to the new BrowserTab actor

Depends on D30045

Comment 16

[Neil Deakin]

Attachment: Bug 1533948, port Browser:HasSiblings message to the new BrowserTab actor

Depends on D30048

Comment 17

[Neil Deakin]

Attachment: Bug 1533948, port MixedContent:ReenableProtection message to the new BrowserTab actor

Depends on D30050

Comment 18

[Neil Deakin]

Attachment: Bug 1533948, port SwitchDocumentDirection message to the new BrowserTab actor

Depends on D30053

Comment 19

[Neil Deakin]

Attachment: Bug 1533948, port UpdateCharacterSet message to the new BrowserTab actor

Depends on D30055

Comment 20

[Neil Deakin]

The patches here seem to mostly work in some cases. Random failures occur while browsing with these patches applied, such as null frame loaders, null documents and so forth.

You can see some of these issues on browser tests:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8eaceec194f23a9be588b390d96fcc619eec7203

Some can be reproduced when running the tests locally, others can be seen randomly while browsing.

A crash will occur if opening about:config at https://searchfox.org/mozilla-central/source/dom/ipc/JSWindowActorChild.cpp#46 because mParent is null.

Comment 21

[Neil Deakin]

Nika, do you know why the issues above might be occurring (random null objects, crash,...), or who I should ask?

Comment 22

[Nika Layzell [:nika] (ni? for response)]

(In reply to Neil Deakin from comment #20)

The patches here seem to mostly work in some cases. Random failures occur while browsing with these patches applied, such as null frame loaders, null documents and so forth.

That's interesting. If you can isolate a situation where you're finding one of these is null unexpectedly it would be good to know. I tried looking at some of the issues behind the link and wasn't able to glean too much off of them, as they mostly looked like timeouts, and I didn't see any obvious JS errors being raised due to a null pointer in my quick scan.

A crash will occur if opening about:config at https://searchfox.org/mozilla-central/source/dom/ipc/JSWindowActorChild.cpp#46 because mParent is null.

Oops, that is 100% our bad. I've got some patches up in bug 1550613 which should make that issue go away.

Comment 23

[Neil Deakin]

Attachment: Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r?mconley

Comment 24

[Neil Deakin]

Note that the patch here includes hack for the Browser:AppTab message due to bug 1523638.

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61dee4121753
change BrowserTabChild to inherit from JSWindowActor, r=mconley

Comment 26

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/61dee4121753

Comment 27

[u636583]

got some of these:

JavaScript error: resource:///actors/BrowserTabParent.jsm, line 32: TypeError: undefined has no properties
JavaScript error: , line 0: NS_ERROR_UNEXPECTED: 
JavaScript error: resource:///actors/BrowserTabParent.jsm, line 27: TypeError: undefined is not a function
JavaScript error: , line 0: NS_ERROR_UNEXPECTED: 
JavaScript error: resource:///actors/BrowserTabParent.jsm, line 27: TypeError: undefined is not a function
JavaScript error: , line 0: NS_ERROR_UNEXPECTED: 
JavaScript error: resource:///actors/BrowserTabParent.jsm, line 32: TypeError: undefined has no properties
JavaScript error: , line 0: NS_ERROR_UNEXPECTED: 

./browser/actors/BrowserTabParent.jsm:

    switch (message.name) {
      case "Browser:WindowCreated": {
        gBrowser.announceWindowCreated(browser, message.data.userContextId);  // line 27                                
        break;
      }

      case "Browser:FirstPaint": {
        browser.ownerGlobal.gBrowserInit._firstBrowserPaintDeferred.resolve();  // line 32
        break;
      }

firefox used:
changeset: 479096:9b4c8fb46d85
tag: tip
parent: 479094:e593e11eff08
parent: 479095:adc12b4c5a9d
date: Tue Jun 18 07:10:14 2019 +0300
summary: Merge inbound to mozilla-central. a=merge