1664972 - Phabricator revisions are not being marked as public

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect, P1)

Description

[:glob ✱]

phabbugz appears to be broken, revisions such as https://phabricator.services.mozilla.com/D90188 are still restricted long after submission.

I see the following error in the logs:

Can't call method "can_see_bug" on an undefined value at /app/extensions/PhabBugz/lib/Feed.pm

Comment 1

[:glob ✱]

Looks like it's stuck on https://phabricator.services.mozilla.com/D85233

REVISION CHANGE FOUND: D85233: Bug 1655636 - avoid reinitializing the timers for ProcessOutputAndEvents, r=dragana | bug: 1655636 | dragana | dragana updated the diff for D85233: Bug 1655636 - avoid reinitializing the timers for ProcessOutputAndEvents, r=dragana.

Bug 1655636 is a valid bug.

Comment 2

[:glob ✱]

The code that's failing is $revision->author->bugzilla_user->can_see_bug($revision->bug_id)

The revision's author, JuniorHsu <PHID-USER-jp2bzmvhg255ln66gcsp>, is linked to a Bugzilla account that no longer exists ([e-mail]).

Comment 3

[:glob ✱]

I think what happened is the Bugzilla account that was linked with Junior's Phabricator account (id 501232) was merged into their personal account (id 611900), resulting in a broken link as 501232 no long exists.

Comment 4

[:glob ✱]

I updated the user_externalaccount.accountID value for PHID-USER-jp2bzmvhg255ln66gcsp to 611900, however this didn't fix the issue.

I wonder if the externalaccount id is part of the feed, so the message stuck in the queue still has the old value?

Comment 5

[:glob ✱]

dkl - can you please look at this when you're online?

Comment 6

[:glob ✱]

This has been fixed.

Comment 7

[David Lawrence [:dkl]]

Reason for failure

• A merge was done from [e-mail] to [e-mail] after the juhsu account was deactivated.
• The juhsu@m account was tied to the Phabricator account.
• The BMO ID in Phabricator for JuniorHsu was no longer an ID that existed in the BMO database.
• Phabbot could not load the user because of this and the feed process came to a halt.
• We were able to manually update the BMO ID in Phabricator in user_externalaccount.accountID and user_externalaccountidentifier.identifierRaw to the BMO ID for [e-mail].
• After that the error cleared and the feed process was able to get all caught up.

If we had instead merged [e-mail] into [e-mail] and then changed the email address to cuveehsu this would have worked as far as the proper BMO ID linking was concerned. The user would still need to login to Phabricator to change the primary email account from the @mozilla.com address. Otherwise bouncing would still occur.