1665064 - Print preview shows background images, even though it's disselected

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

STR:

1. Open about:newtab
2. Open the print dialog
3. Select Save to PDF as destination
4. Hit save and observe the generated PDF document

ER: print preview and PDF should show a similar result
AR: the PDF does no contain images that are shown in the print preview

Comment 1

[Martin Balfanz [:mbalfanz]]

about:newtab uses background-image to display the top-site icons. This is also a common practice on many other websites, e.g. to place logos in the header. I observed that those situations get confusing, because the print preview shows those images, but the resulting print does not.

Selecting the "print backgrounds" option shows all images as expected.

Comment 2

[Martin Balfanz [:mbalfanz]]

Finding some more examples, like the footer on https://www.mozilla.org/en-US/firefox/developer/

The print preview shows an unreadable result, because it contains the background-image. The generated PDF is perfectly fine.

I think it would be best if the preview ignores background images (and makes the necessary text color adjustment) the same way the print output does, so I moved the bug to the "Print Preview" component.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Yeah, looks borked.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Can you confirm that disabling webrender makes it work?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1665064 - Honor print background image settings on WebRender too. r=kats,jwatt

We usually suppress background images in
nsCSSRendering::PaintStyleImageLayerWithSC, but that codepath isn't hit
by WebRender, so instead do it during display list building, the same
way we suppress background colors.

Comment 6

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2020-09-15 at 17.07.49.png

Can't confirm. Here's a screenshot of me running a fresh profile on OS X without webrender

Comment 7

[Martin Balfanz [:mbalfanz]]

Whoops, scratch that.

I can confirm that it works as expected when running Firefox with MOZ_WEBRENDER=0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a572a639204f
Honor print background image settings on WebRender too. r=kats,jwatt

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/c4d96dad44b16ca9447beac3933dcfb893013077
Failures on float-clear-000-print.html -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315771523&repo=autoland&lineNumber=6093
Failures on page-width-3.9in.htm -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315773319&repo=autoland&lineNumber=8224
Failures on nested-overflow-subtree-layout.html -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315771539&repo=autoland&lineNumber=21077

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01991b20e8a2
Honor print background image settings on WebRender too. r=kats,jwatt CLOSED TREE

Comment 11

[Narcis Beleuzu [:NarcisB]]

Re-landed because this bug didn`t cause the failures

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/01991b20e8a2

Comment 13

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 83.0a1 (2020-09-29) on Mac OS 10.14, Window 10 x64 and on Ubuntu 20.04 x64.