1668762 - [PI-819] Images are not displayed on the print preview before printing at least once using the old UI on Windows

Status: RESOLVED DUPLICATE of bug 1669187

(Core :: Print Preview, defect, P2)

Description

[Patriciu Pop [:ppop], Ecosystem QA]

Attachment: print_images.gif

[Affected versions]:

• Firefox Beta 82.0b5, Build ID 20200929175845

[Affected platforms]:

• Windows 10 x64

[Prerequisites]:

• Have the "print.tab_modal.enabled" pref set as "false".

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and navigate to the about:newtab page.
2. Click the hamburger menu button and click the "Print..." option.
3. Click the "Page Setup..." button and check the "Print Background (colors & images)" checkbox.
4. Observe the behavior.

[Expected result]:

• The print preview is refreshed and the images are displayed.

[Actual result]:

• The print preview is refreshed and no images appear on the page.

[Regression]:

• I have managed to find a regression window, using the Mozregression tool. Here are the results:
  Last good revision: 2742f1d85634ae4dfc169b98dd537f4091118cf5
  First bad revision: 01991b20e8a2505b6b6edd41015f915fdacca01b
  Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2742f1d85634ae4dfc169b98dd537f4091118cf5&tochange=01991b20e8a2505b6b6edd41015f915fdacca01b
• From the pushlog, it seems that Bug 1665064 might have caused this issue.

[Notes]:

• This issue is not reproducible using the new UI.
• Workaround: The print preview correctly displays images after printing to PDF at least once.
• This issue is not reproducible on macOS and linux.
• Attached a screen recording of the issue:

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Regression for the old UI. Tentatively tracking this for 82.

Comment 2

[Sean Voisen (:svoisen)]

ni? emilio based on the regressing bug, but I'm setting this at P2.

Comment 3

[Jonathan Watt [:jwatt]]

Suspiciously similar to bug 1668621, even if the regressing commit is different. The patch for that bug may fix this one too.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yeah, I think this is just bug 1668621. I think my patch just uncovered the settings difference because we used not to honor them.

Comment 5

[Jonathan Watt [:jwatt]]

The patch for bug 1669187 fixes this, at least to the extent we can without taking on too much risk.