1665123 - Search start-up service intialization browser console error

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

[Sugested Severity:]

S4 until investigated

[Description:]

First startup + fast type @ in the address bar

[Environment:]

Ubuntu 20.04 / Windows 10
82.0a1 2020-09-15

[Steps:]

1. Create a new profile.
2. At fist start-up fast type @ in the addressbar.

[Actual Result:]

Error: Something tried to use the search service before it's been properly intialized. Please examine the stack trace to figure out what and where to fix it:
_ensureinitialized@resource://gre/modules/searchservice.jsm:233:15
getenginebyname@resource://gre/modules/searchservice.jsm:1408:10
setsearchmode@resource:///modules/urlbarinput.jsm:1270:34
seturi@resource:///modules/urlbarinput.jsm:364:12
onlocationchange@chrome://browser/content/browser.js:5289:15
calllisteners@chrome://browser/content/tabbrowser.js:832:31
_callprogresslisteners@chrome://browser/content/tabbrowser.js:846:22
_callprogresslisteners@chrome://browser/content/tabbrowser.js:5826:46
onlocationchange@chrome://browser/content/tabbrowser.js:6239:14
SearchService.jsm:233:15

[Note:]

1. It's a bit intermittent, so a slow PC would help.
2. This might also be a search shortcuts (bug 1644572) related issue, but blocking post-modernization first for investigation.

Comment 1

[Mark Banner (:standard8)]

This is the address bar (search shortcuts) trying to access the search service too early and not checking if it is initialised first:

https://searchfox.org/mozilla-central/rev/30e70f2fe80c97bfbfcd975e68538cefd7f58b2a/browser/components/urlbar/UrlbarInput.jsm#1270

Comment 2

[Harry Twyford]

Attachment: Bug 1665123 - Avoid early calls to setSearchMode and add a check for search service initialization. r?adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60314c2f5125
Avoid early calls to setSearchMode and add a check for search service initialization. r=adw

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/60314c2f5125

Comment 5

[Adrian Florinescu [:aflorinescu]]

Verified that the search initialization issue is solved on Win10 - 82.0b7. However, given that the search shortcuts is now disabled on 82, this is not entirely relevant, so moving the flags to keep this bug tracked for further verification on 83.

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue using Fx82.0a1 on Ubuntu and Windows as mentioned in the bug.
Verified the issue using the latest Fx83.0a1 on Windows 10 and Ubuntu 18.04. The eror is no longer when '@' is typed as soon as Firefox starts.