1665131 - Search Settings may attempt to be written whilst the search service is still initialising

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Mark Banner (:standard8)]

I noticed this whilst checking tests for errors - the changes added in bug 1642995 to set the new search order, may cause us to attempt to write the initialisation file before the service has initialised.

As a result, the search data may be incomplete.

Really, the settings should just prevent trying to save whilst initialisation or reloading engines is in progress.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1665131 - Ensure search settings are not attempted to be written during initialisation or reloading engines. r?daleharvey!

Depends on D90095

Comment 2

[Mark Banner (:standard8)]

Note: I suspect this is less likely to happen in the real world. The tests shorten the delayed write time and so would hit it more frequently, the normal timeout is around a second, and in a lot of cases (not all) the search service has finished initialising by then.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a687e03dcc9d
Ensure search settings are not attempted to be written during initialisation or reloading engines. r=daleharvey

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a687e03dcc9d