1665294 - Using close search-mode will also remove the next alias (if any)

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

[Sugested Severity:]

S3

[Environment:]

Ubuntu 20.04 / Windows 10 / Mac 10.13.6
82.0a1 2020-09-15

[Steps:]

1. Open Firefox.
2. New tab.
3. type @google @amazon @ddg @google
4. Click x on google search-mode indicator

[Actual Result:]

[ddg search-mode] @google

[Expected Result:]

[amazon search-mode] @ddg @google

[Note:]

Another way to look at it would be to use "@google @google @google @google @google @google", then close the google search mode, which would remove [google search-mode] + next @google, then will translate the next @google alias into [google search-mode], then close again, repeat.

[Regression-Range:]

This seems to be a recent regression, since in Firefox 81 with the update2.* on, I cannot reproduce.

Comment 1

[Marco Bonardo [:mak]]

it sounds like an edge case, should be investigated but it's probably not a show-stopper.

Comment 2

[Alin Ilea, Desktop Test Engineering]

Regression Range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2e2abe718eb21d36932b373f587d11819d0a3674&tochange=6c384e44f2e40426da3fbdcc044ac300206b9850

Maybe regressed by: https://bugzilla.mozilla.org/show_bug.cgi?id=1658964
@Drew, could you take a look over this?

Thanks.

Comment 3

[Drew Willcoxon :adw]

Yes, that bug is likely, but I agree with Marco that this isn't urgent, and I'm currently working on higher priority update2 bugs. We'll certainly get to this eventually.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: remove-aliases.mp4

I checked this one, but could not reproduce this on current m-c.
(Please see the attachment)

Could you please check it, Adrian??
Or, If I am misunderstanding, please let me know.

Thanks.

Comment 5

[Adrian Florinescu [:aflorinescu]]

Interesting, now mac is behaving properly (10.13.6) but it can still can be reproduced on W10 with latest Nightly 83.0a1 20201012152719.

Comment 6

[Adrian Florinescu [:aflorinescu]]

Attachment: Firefox Nightly 2020-10-13 16-56-41.mp4

Comment 7

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Adrian!
Yes, and I can reproduce this on ubuntu 18.04 as well.

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1665294: Avoid capturing click event twice from search mode close button.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61dae93abcb1
Avoid capturing click event twice from search mode close button. r=mak

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/61dae93abcb1

Comment 11

[Florencia Di Ciocco, NI to vbalducci]

Hi,

I tested this on W10 on FF 83.0a1 20201012152719, reproduced the issue and then tested it on FF 85.0a1 (2020-12-01) (64-bit) and verified that it's fixed. I also checked it on Beta and release.

Regards, Flor.