1665327 - max-height affects the inline-size computed through an aspect ratio for non-replaced elements

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Boris Chiou [:boris]]

This bug should address the size constraints when using aspect-ratio property.
See https://drafts.csswg.org/css-sizing-4/#aspect-ratio:

Additionally, sizing constraints in either axis (the origin axis) are transferred through the preferred aspect ratio to the other axis (the destination axis) as follows:

• First, any definite minimum size is converted and transferred from the origin to destination axis. This transferred minimum is capped by any definite preferred or maximum size in the destination axis.
• Then, any definite maximum size is converted and transferred from the origin to destination. This transferred maximum is floored by any definite preferred or minimum size in the destination axis as well as by the transferred minimum, if any.

The relevant wpts are:
css-sizing/aspect-ratio/block-aspect-ratio-020.tentative.html
to
css-sizing/aspect-ratio/block-aspect-ratio-028.tentative.html

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1665327 - Factor out the computation of min/max inline size for better readability.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1665327 - Support transferred {min|max} inline-size by using definite {min|max} block-size and aspect-ratio for non-replaced elements.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1665327 - Move the computation of min/max block size for better readability.

Just move the computation of min and max block sizes into a static function,
so we may merge the implemntation with that in ReflowInput::ComputeMinMaxValues.

Comment 4

[Boris Chiou [:boris]]

It seems we always calculate the inline size first, and so we know the block size through aspect-ratio, so transferred min/max block size may not take effect. Perhaps this is a potential bug. For now, I'd like to handle the inline case in this bug.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1665327 - The minor refactoring to avoid duplicate code when checking if the {min|max} block-size is auto.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/806282a39a35
Support transferred {min|max} inline-size by using definite {min|max} block-size and aspect-ratio for non-replaced elements. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/3fdcc3ca998a
The minor refactoring to avoid duplicate code when checking if the {min|max} block-size is auto. r=TYLin

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/806282a39a35
https://hg.mozilla.org/mozilla-central/rev/3fdcc3ca998a