1665413 - Perma on Late Beta REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/svg/as-image/canvas-drawImage-alpha-2.html == layout/reftests/svg/as-image/canvas-drawImage-alpha-2-ref.html | image comparison, max difference: 1 when 82 becomes late Beta on 2020-10-02

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect, P1)

Description

[Razvan Maries]

[Tracking Requested - why for this release]:

Late Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=YzyVPtK0SSSw8Bwm8ZmOtA.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=ef554a8be6eb26910bec9f9bb4e29bc8c34d44b0&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cshippable%2Copt%2Creftests%2Ctest-windows10-64-shippable-qr%2Fopt-reftest-e10s%2Cr1

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315848752&repo=try&lineNumber=15196

Last green job on late beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=28b47eafcd46278db37983f55d2dd779453279ec&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cshippable%2Copt%2Creftests%2Ctest-windows10-64-shippable-qr%2Fopt-reftest-e10s%2Cr1&selectedTaskRun=QD-OF2wxS3qUS-UZ3g9iGA.0

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Do we know what regressed this? Seems like a fuzzy WebRender failure.

Comment 3

[Andreea Pavel [:apavel]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Do we know what regressed this? Seems like a fuzzy WebRender failure.

This showed up on the merge for the beta sim from 11th of September, having this base revision:
https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=3618085622203ef418c62c3d99199485c99e0e51

Nicholas can this be from Bug 1664105 ?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

My guess is that this is caused by remote canvas being turned off.

Comment 5

[Nicholas Nethercote [inactive]]

Nicholas can this be from Bug 1664105 ?

It seems unlikely, but kvark might know better?

Comment 6

[Bob Owen (:bobowen)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)

My guess is that this is caused by remote canvas being turned off.

I guess that's the trigger, but won't be the underlying cause.

I guess we don't see it with remote canvas because of bug https://bugzilla.mozilla.org/show_bug.cgi?id=1660661.
Maybe the non-remote case should have been updated as well.
I assume it was a different bug that actually caused the pixel change.

Comment 7

[Bob Owen (:bobowen)]

It landed with the wrong bug number:
https://hg.mozilla.org/mozilla-central/rev/86ec8b287a676330cca66c661fdef8efc519e06c

Comment 8

[Dzmitry Malyshau [:kvark]]

RON doesn't participate in reftesting, so shouldn't be related to Bug 1664105

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Bob, the patch is older than this bug.
Maybe this needs some other changes?

Comment 10

[Intermittent Failures Robot]

2 failures in 4019 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• windows10-64-shippable-qr: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-09-21&endday=2020-09-27&tree=all

Comment 11

[Intermittent Failures Robot]

1 failures in 4195 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-09-28&endday=2020-10-04&tree=all

Comment 12

[Intermittent Failures Robot]

5 failures in 4130 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 3
• try: 2

Platform breakdown:

• windows10-64-shippable-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-10-05&endday=2020-10-11&tree=all

Comment 13

[Intermittent Failures Robot]

5 failures in 3694 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1
• mozilla-release: 3
• try: 1

Platform breakdown:

• windows10-64-shippable-qr: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-10-12&endday=2020-10-18&tree=all

Comment 14

[Intermittent Failures Robot]

4 failures in 4230 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 2
• try: 2

Platform breakdown:

• windows10-64-shippable-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-10-19&endday=2020-10-25&tree=all

Comment 15

[Intermittent Failures Robot]

11 failures in 4275 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 4
• try: 2
• mozilla-beta: 5

Platform breakdown:

• windows10-64-shippable-qr: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-10-26&endday=2020-11-01&tree=all

Comment 16

[Bob Owen (:bobowen)]

Attachment: Bug 1665413: Adjust fuzz for canvas-drawImage-alpha-2.html on Windows webrender with remote canvas disabled. r=jrmuizel!

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae07f850ba6
Adjust fuzz for canvas-drawImage-alpha-2.html on Windows webrender with remote canvas disabled. r=jrmuizel

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8ae07f850ba6

Comment 19

[Bob Owen (:bobowen)]

Comment on attachment 9185552 [details]
Bug 1665413: Adjust fuzz for canvas-drawImage-alpha-2.html on Windows webrender with remote canvas disabled. r=jrmuizel!

Beta/Release Uplift Approval Request

• User impact if declined: None, just requesting in case we want to silence a perma-orange in late beta and release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Test change only.
• String changes made/needed: None

Comment 20

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9185552 [details]
Bug 1665413: Adjust fuzz for canvas-drawImage-alpha-2.html on Windows webrender with remote canvas disabled. r=jrmuizel!

Approved for 83 beta9, thanks

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4765e55ebd2

Comment 22

[Intermittent Failures Robot]

9 failures in 4128 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 4
• try: 1
• mozilla-beta: 4

Platform breakdown:

• windows10-64-shippable-qr: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1665413&startday=2020-11-02&endday=2020-11-08&tree=all